Refactor to be more pythonic #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some more changes are possible to have easier build/deploy (using pbr).
|
Thanks, I'll take a look at your pull request in detail. It may take me a few days to dig in. Would you please give me a bit more detail on your changes. More pythonic is nice to know but I need more explanation, please. |
|
I moved the things around (split code and tests), changed the package structure to make it more standard, as there was an unnecessary level. I also fixed some PEP8 conventions. I simplified operations (a = a+1 becomes a += 1). Nothing else. |
Open
|
#3 is much better than this one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.