Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to ruff #466

Closed
wants to merge 4 commits into from
Closed

chore: switch to ruff #466

wants to merge 4 commits into from

Conversation

domoritz
Copy link
Member

Depends on astral-sh/ruff#282

`ruff` exited with an error previously after `make lint`, with
*error: The following required arguments were not provided: <FILES>...*
@peter-gy
Copy link
Collaborator

@domoritz, we discussed at one of our meetings that we are running lint checks both as part of the pre-commit check and the test.yml#lint job. Can we get rid of the latter?

@domoritz
Copy link
Member Author

Yes, we can. Didn't we already remove it?

@domoritz
Copy link
Member Author

Replaced by #507

@domoritz domoritz closed this Feb 22, 2023
@domoritz domoritz deleted the dom/ruff branch February 22, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants