-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Editor displays gymlib correctly (#63)
**Summary**: The editor is now able to find the gymlib library and display the types correctly. **Demo**: Works in dbgym. <img width="455" alt="Screenshot 2024-12-25 at 19 36 46" src="https://github.com/user-attachments/assets/22efa678-7267-4d62-858a-c24a2bd382a0" /> Works in hello-tune agent. <img width="450" alt="Screenshot 2024-12-25 at 19 36 50" src="https://github.com/user-attachments/assets/87ebe1aa-6293-4f0c-abcc-a8bafba07062" /> **Details**: * In the previous PR we got the system running but the editor didn't display it correctly. * This works in both dbgym and agent.
- Loading branch information
1 parent
4db0947
commit 3b304aa
Showing
9 changed files
with
17 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import gymlib | ||
|
||
print(gymlib.magic.get_magic_number()) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
#!/bin/bash | ||
# Ignore agents/ because those are all submodules. | ||
mypy --config-file scripts/configs/mypy.ini . --exclude agents/ | ||
# Ignore gymlib_package/build/ to avoid the error of mypy finding two gymlib packages. | ||
mypy --config-file scripts/configs/mypy.ini . --exclude agents/ --exclude gymlib_package/build/ |