Fix bugs with TPCH implementation #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…match the specification
…n meant that for at least some databases the correct query text is used anyways, which is why there were not errors from mismatching # and type of query parameters.
had 'ETHIOPIA' hardcoded for one of the nation keys.
apavlo
requested changes
Jul 6, 2022
Comment on lines
59
to
60
| protected final <T extends Procedure> T initialize(WorkloadConfiguration workConf) { | ||
| this.workConf = workConf; |
There was a problem hiding this comment.
I don't think we should do this. It makes it more brittle since WorkloadConfiguration is basically a dumping ground for everything. Let's revert this and only pass in DatabaseType.
| @@ -63,12 +63,12 @@ protected PreparedStatement getStatement(Connection conn, RandomGenerator rand) | |||
| String nation = TPCHUtil.choice(TPCHConstants.N_NAME, rand); | |||
|
|
|||
| // FRACTION is chosen as 0.0001 / SF | |||
| // TODO: we should technically pass dbgen's SF down here somehow | |||
| double fraction = 0.0001; | |||
| double fraction = 0.0001 / this.workConf.getScaleFactor(); | |||
There was a problem hiding this comment.
We should pass this in as an input parameter to getStatement()
There was a problem hiding this comment.
I've refactored it to pass scale factor to getStatement. The changes are all restricted to benchmarks/tpch now instead of changing the generic api.
…king the whole configuration available.
apavlo
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fixes a few bugs with the TPCH queries where it does not match the specification. Note: each fix is a separate commit so they can be reviewed independently if that is easier. (I can also split into multiple PRs if preferred, but the changes are pretty small)
Procedurebase class duringinitializeinstead of just the database type, but if there is a better way to access the scale factor I am happy to change this.