Docker build as root fixups #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CONTAINERUSER_UID CONTAINERUSER_GID instead of UID/GID directly. Allow those to be supplied as environment variable overrides. If not available, default to UID/GID as before. If those are 0 (root, which already exists in the container), then try to look at the SUDO_UID environment variable. Note: It doesn't yet handle the fixup required to the RUN command if those are still set to 0.
…can be created as uid 0 (root)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
containeruser
UIDGIDfixups for when using the script to build as root.Use
CONTAINERUSER_UIDCONTAINERUSER_GIDinstead ofUIDGIDdirectly.Allow those to be supplied as environment variable overrides (e.g.
CONTAINERUSER_UID=1234 ./build-full-image.sh)If not available, default to
UIDGIDas before.If those are
0(root, which already exists in the container), then tryto look at the
SUDO_UIDenvironment variable.Also fixes up the Dockerfile to support creating a
containeruserwith an overlapping uid (e.g.0) in case all of the above workarounds are insufficient.