Fix serial execution start and reset. #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed wrong execution of serial TPC-H benchmark due to a) state being set to WARMUP even though serial execution does not require a warm-up phase, b) workers being started right after initialization due to single-threaded execution, and c) an incorrect reset for serial after a phase has finished. This resulted in unnecessary query executions during the warm-up phase and skipped cold queries for Q1 in all phases after the first one.
-- Added a synchronized state adjustment for serial execution to set state to COLD_QUERY before workers are started.
-- Added a synchronized state adjustment when execution is reset between phases.