Random Seed + Thread-local Random + Better Epinions Tables #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oss the benchmarks. You can now also pass in <randomSeed> in the config to ensure more deterministic benchmark runs. * Better multi-threaded loading for EpinionsLoader. * Expanded schema for Epinions to make each record larger. * Code refactoring + cleanup.
apavlo
added
enhancement
…ormatting but it was the only one that I could find that could handle all the queries
timveil
reviewed
Mar 30, 2022
| + "order by " | ||
| + "l_returnflag, " | ||
| + "l_linestatus" | ||
| public final SQLStmt query_stmt = new SQLStmt(""" |
There was a problem hiding this comment.
love this change... moving to text blocks... so much easier to read. i had this on my todo list for all benchmarks!
timveil
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from my branch for the course. I did not bring in the new timeseries + indexjungle benchmarks.