Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two small optimizations for SEATS on CockroachDB #136

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Two small optimizations for SEATS on CockroachDB #136

merged 2 commits into from
Mar 17, 2022

Conversation

mgoddard
Copy link
Contributor

This PR includes the following two changes to improve SEATS performance:

  1. Copied the dialect-postgres.xml over to dialect-cockroachdb.xml
  2. Altered and renamed the secondary index on the flight table

These changes, 2 in particular, yielded significant improvement in the runtime of the queries joining the flight and airline tables.

@timveil timveil self-requested a review March 16, 2022 19:01
timveil
timveil approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@timveil timveil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes look good to me

@timveil timveil requested a review from apavlo March 16, 2022 19:02
@timveil timveil added the ready-for-review This PR is ready to be reviewed. label Mar 16, 2022
@timveil timveil merged commit aa20749 into cmu-db:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timveil timveil timveil approved these changes

@apavlo apavlo Awaiting requested review from apavlo

Assignees
No one assigned
Labels
ready-for-review This PR is ready to be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgoddard @timveil