forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mts implementation #31
Draft
federicovazzoler
wants to merge
24
commits into
cms-trackeralign:newAllInOneToolAligned
Choose a base branch
from
federicovazzoler:MTS_implementation
base: newAllInOneToolAligned
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Mts implementation #31
federicovazzoler
wants to merge
24
commits into
cms-trackeralign:newAllInOneToolAligned
from
federicovazzoler:MTS_implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler/cmssw into MTS_implementation
… 'process.cosmicValidation'. To be updated in the future
…l. Only 'single' supported atm
…nt in order to be prased by the validateAlignment.py tool. To be fixed
mmusich
reviewed
Jan 8, 2024
if "merge" in config["validations"]["MTS"] or \ | ||
"trends" in config["validations"]["MTS"] or \ | ||
"averaged" in config["validations"]["MTS"]: | ||
print("WARNING: 'merge', 'trends' and 'averaged' not yet supported. Will do nothing for them.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a version of this branch in which the merge
step is implemented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTS implementation on the newAllInOneToolAlligned tool
This is a draft pull request. The head repository needs to be pruned by useless commits before merging.