-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize makeTrackValidationPlots.py script #9949
Generalize makeTrackValidationPlots.py script #9949
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Generalize makeTrackValidationPlots.py script It involves the following packages: Validation/RecoTrack @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
…racking/Track in the DQM files
a31046a
to
a7d1ed8
Compare
Noticed a small bug right after pushing "submit PR" button, fixed and squashed to the existing commit. |
Pull request #9949 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again. |
Hi Matti I have some troubles running this. I run
This complaints about some histograms not found. Thanks Lukas |
Thanks, I'll take a look (and close this for time being). |
@lveldere The missing histograms were due to 2D-histograms nhits_vs_eta and chi2_vs_eta that were cleaned up in #9524. As they were used only to make "ProfileX()", I switched the plotting to use the profiles existing in DQM file (should've done this in #9524...). In addition, I added |
Pull request #9949 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again. |
Great, that works! Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Generalize makeTrackValidationPlots.py script
This PR generalizes the
makeTrackValidationPlots.py
script introduced in #9882 to make plots for all subfolders of "Tracking/Track" folder of the first of the DQM files given as command line arguments (feature requested by @lveldere). Add also--ignoreMissing
command line flag to allow skipping missing histograms/subfolders.In addition, switch the plotting to use the profile histograms in the DQM files instead of the 2D histograms nhits_vs_eta and chi2_vs_eta that were cleaned up in #9524.
There should be no effect on standard workflows.
@rovere @VinInn