Skip to content

[15_0_X] Developing offline JetMET DQM for Scouting jets + applying JetID criteria #47935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

etzovara
Copy link
Contributor

PR description:

This PR is a backport of PRs #47328 and #47721 . It adds the hltScoutingJetDqmOffline sequence to the @hltScouting DQM sequence and to connect the PR 47212 with the PR 47235. It also adds the JetID criteria for Scouting jets.

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of PRs #47328 and #47721 . This backport is meant for the CMSSW_15_0_X releases so that the Offline Scouting DQM developments are linked and complete in all these releases.

…sed to avoid crashes with datasets other than ScoutingPFMonitor)
…e DQM - from 'JetMET/Jet/' to 'HLT/ScoutingOffline/Jet/'- so that all the scouting objects are in the same directory
…lyzer for events passing scouting JetID citeria
…leaned' output directory and histogrms for events passing the scouting JetID criteria
…D criteria for scouting jets (in accordance with PFJetIDSelectionFunctor.h)
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2025

A new Pull Request was created by @etzovara for CMSSW_15_0_X.

It involves the following packages:

  • DQMOffline/HLTScouting (dqm)
  • DQMOffline/JetMET (dqm)
  • PhysicsTools/SelectorUtils (reconstruction)

@antoniovagnerini, @cmsbuild, @jfernan2, @mandrenguyen, @rseidita can you please review it and eventually sign? Thanks.
@ahinzmann, @gkasieczka, @jdamgov, @jdolen, @mariadalfonso, @missirol, @mmarionncern, @mmusich, @nhanvtran, @rappoccio, @rociovilar, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Apr 23, 2025

backport of #47328

@mmusich
Copy link
Contributor

mmusich commented Apr 23, 2025

backport of #47721

@mmusich
Copy link
Contributor

mmusich commented Apr 23, 2025

test parameters:

  • workflow = 145.415

@mmusich
Copy link
Contributor

mmusich commented Apr 23, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d531d4/45688/summary.html
COMMIT: 4245cc1
CMSSW: CMSSW_15_0_X_2025-04-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47935/45688/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4100731
  • DQMHistoTests: Total failures: 132
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4100579
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 177.229 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 177.229 KiB HLT/ScoutingOffline
  • Checked 221 log files, 193 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 49 workflows

@etzovara
Copy link
Contributor Author

@mmusich how this conflict will be resolved? It has to do with the PR #47923.

@mmusich
Copy link
Contributor

mmusich commented Apr 24, 2025

@etzovara

how this conflict will be resolved? It has to do with the PR #47923.

You can have a look on how to deal with conflicts at https://cms-sw.github.io/tutorial-resolve-conflicts.html.
Otherwise you can try simply with:

git rebase -i CMSSW_15_0_X

then, when you hit the conflict, edit the file DQMOffline/HLTScouting/python/HLTScoutingDqmOffline_cff.py such that it looks like this:

'''
Scouting DQM sequences for offline DQM developed for 2025 pp data-taking
and used by DQM GUI (DQMOffline/Configuration):
currently running EGM and MUO monitoring modules.
'''

import FWCore.ParameterSet.Config as cms
from DQMServices.Core.DQMEDHarvester import DQMEDHarvester                                

from HLTriggerOffline.Scouting.ScoutingMuonTriggerAnalyzer_cfi import *
from HLTriggerOffline.Scouting.ScoutingMuonTagProbeAnalyzer_cfi import *
from HLTriggerOffline.Scouting.ScoutingMuonMonitoring_Client_cff import *


from HLTriggerOffline.Scouting.HLTScoutingEGammaDqmOffline_cff import *
from HLTriggerOffline.Scouting.ScoutingCollectionMonitor_cfi import *

from DQMOffline.JetMET.jetMETDQMOfflineSource_cff import *

hltScoutingMuonDqmOffline = cms.Sequence(scoutingMonitoringTagProbeMuonNoVtx
                                         * scoutingMonitoringTagProbeMuonVtx                                                         
                                         * scoutingMonitoringTriggerMuon                                                              
)

hltScoutingCollectionMonitor = cms.Sequence(scoutingCollectionMonitor)

hltScoutingJetDqmOffline = cms.Sequence(jetMETDQMOfflineSourceScouting)

hltScoutingDqmOffline = cms.Sequence(hltScoutingMuonDqmOffline + hltScoutingEGammaDqmOffline + hltScoutingCollectionMonitor + hltScoutingJetDqmOffline)

and then:

git commit
git rebase --continue
git push my-cmssw +HEAD:JetMETScoutDQM_150X

@mandrenguyen mandrenguyen changed the title Backport: Developing offline JetMET DQM for Scouting jets + applying JetID criteria [15_0_X] Developing offline JetMET DQM for Scouting jets + applying JetID criteria Apr 24, 2025
@cmsbuild
Copy link
Contributor

Pull request #47935 was updated. @antoniovagnerini, @cmsbuild, @jfernan2, @mandrenguyen, @rseidita can you please check and sign again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants