Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex187X Add a test script to test all scenarios of 2021 #47243

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Feb 3, 2025

PR description:

Add a test script to test all scenarios of 2021

PR validation:

This script is used to verify all scenarios of 2021 (zero material, flat+-n%)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

cms-bot internal usage

@bsunanda
Copy link
Contributor Author

bsunanda commented Feb 3, 2025

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • SimG4CMS/Calo (simulation)

@civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @fabiocos, @felicepantaleo, @martinamalberti, @rovere, @slomeo, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here


####################################################################
### SETUP OPTIONS
options = VarParsing.VarParsing('standard')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informational comment: while VarParsing is still allowed, it should be considered deprecated and argparse should be preferred, since it is now supported by cmsRun (since #42650). An example migration can be found here: ec33ffd

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-803bfc/44147/summary.html
COMMIT: f1bb2d6
CMSSW: CMSSW_15_0_X_2025-02-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47243/44147/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016938
  • DQMHistoTests: Total failures: 97
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016821
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Feb 3, 2025

+1

I think, VarParsing may be migrated later.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aabdecc into cms-sw:master Feb 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants