Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more limited matrix options, separately for Run1&2, Run3, Phase2 and HeavyIons #47205

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 29, 2025

PR description:

Sometimes when developing a given features that is known to not affect past data / MC (e.g. for Phase2), when testing it's useful to run a subset of workflows from the limited matrix, without waiting for the completion of the whole set containing workflows that are by construction not affected by the changes.
This PR proposes to break down predefinedSet['limited'] in runTheMatrix.py into the sum of smaller sets separately for Run1&2, Run3, Phase2 and HeavyIons.

PR validation:

runTheMatrix.py -l run3 --show
runTheMatrix.py -l run1_run2 --show
runTheMatrix.py -l phase2 --show
runTheMatrix.py -l heavyIons --show

all run fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47205/43476

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fcc97/44047/summary.html
COMMIT: 7a09339
CMSSW: CMSSW_15_0_X_2025-01-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47205/44047/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 19
  • DQMHistoTests: Total histograms compared: 1096738
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1096718
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 18 files compared)
  • Checked 87 log files, 61 edm output root files, 19 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

Apparently the new limited ends up reading only Run1+Run2 for some reason.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47205/43480

@cmsbuild
Copy link
Contributor

Pull request #47205 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jan 30, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fcc97/44063/summary.html
COMMIT: b459e69
CMSSW: CMSSW_15_0_X_2025-01-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47205/44063/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016770
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016747
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 4, 2025

Apparently the new limited ends up reading only Run1+Run2 for some reason.

ciao @AdrianoDee, the last round of tests seems OK to me. Do you have any objection here?

@AdrianoDee
Copy link
Contributor

+pdmv
(and thanks!)

@Moanwar
Copy link
Contributor

Moanwar commented Feb 4, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ab3deda into cms-sw:master Feb 4, 2025
11 checks passed
@mmusich mmusich deleted the mm_dev_more_limited_matrix_options branch February 4, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants