-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SiPixelAliHGRcd_prod.json #47059
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47059/43215 |
A new Pull Request was created by @perrotta for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
the update looks correct, but not for the reasons you list. cmssw/CondFormats/Common/data/SiPixelAliHGCombRcd_prod.json Lines 4 to 5 in 134545c
also it's not in the last IoV of DropBoxMetadata_v8.5_express because it was switched off the 2024 HIon run). |
Thank you @mmusich |
please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR #39553 made on purpose the change which I am reverting here. However, the DropBoxMetadata tags in GT still consider the destinationTags with the string "HG" in it, see e.g. the destinationTags of TrackerAlignmentHGRcd in DropBoxMetadata_v8.5_express.
Not having the "HG" string written explicitly in the SiPixelAliHGRcd_prod.json in the release may produce some confusion when activating/deactivating HG PCL for the tracker Alignment (at least it happened to me when I created DropBoxMetadata_v8.6_express
Of course, since the update I propose to revert here was originally done on purpose I may misunderstand its real usefulness. Therefore, I'd ask @tvami and @mmusich to confirm whether this update makes sense or not: if not, I will close this PR
PR validation:
No changes expected in any workflow.
It can only avoid errors when producing new DropBoxMetadata payloads.