Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SiPixelAliHGRcd_prod.json #47059

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update SiPixelAliHGRcd_prod.json #47059

merged 1 commit into from
Jan 9, 2025

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Jan 8, 2025

PR description:

PR #39553 made on purpose the change which I am reverting here. However, the DropBoxMetadata tags in GT still consider the destinationTags with the string "HG" in it, see e.g. the destinationTags of TrackerAlignmentHGRcd in DropBoxMetadata_v8.5_express.

Not having the "HG" string written explicitly in the SiPixelAliHGRcd_prod.json in the release may produce some confusion when activating/deactivating HG PCL for the tracker Alignment (at least it happened to me when I created DropBoxMetadata_v8.6_express

Of course, since the update I propose to revert here was originally done on purpose I may misunderstand its real usefulness. Therefore, I'd ask @tvami and @mmusich to confirm whether this update makes sense or not: if not, I will close this PR

PR validation:

No changes expected in any workflow.
It can only avoid errors when producing new DropBoxMetadata payloads.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • CondFormats/Common (alca, db)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @seemasharmafnal, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jan 8, 2025

@perrotta

to confirm whether this update makes sense or not: if not, I will close this PR

the update looks correct, but not for the reasons you list.
#39553 correctly moved the LG alignment PCL to _off tags, while putting the HG alignment PCL to the production tag.
In the meantime the HG PCL was superseded by the HG Combined one that is the one that should currently write in the production tag in normal pp operations (this doesn't seem to be reflected in

"SiPixelAliHGCombined_PCL_v0_hlt": {},
"SiPixelAliHGCombined_PCL_v0_prompt": {}

also it's not in the last IoV of DropBoxMetadata_v8.5_express because it was switched off the 2024 HIon run).

@perrotta
Copy link
Contributor Author

perrotta commented Jan 9, 2025

Thank you @mmusich
The purpose of this PR was only to reinsert the "HG" string in the destination tag of the HG key, so that we should simply edit the json file in our own cmssw area and add/remove the "_off" suffix to disable/enable the corresponding workflow: last time I just added "_off", but forgetting to add "HG" I ended up disabling the wrong wf.
Of course, one could even (better?) reflect since now in the configuration in main CMSSW the expected default for the 2025 pp data taking. That was not what was intended with this PR, but it can be done, if requested: if we want to do so, I'd need to cross check with you the expected activation/deactivation map for all those modules in "default" 2025 pp.

@perrotta
Copy link
Contributor Author

perrotta commented Jan 9, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d1e36/43690/summary.html
COMMIT: 3dfb412
CMSSW: CMSSW_15_0_X_2025-01-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47059/43690/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818730
  • DQMHistoTests: Total failures: 388
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818322
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

perrotta commented Jan 9, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants