Run3-alca252X Update the macros to study the forward-backward asymmetry in the correction factors #47042
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47042/43168 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47042/43169 |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
+1 Size: This PR adds an extra 48KB to repository Comparison SummarySummary:
|
| sprintf(name, "hd%d", j + 1); | ||
| int maxd = (depth < 0) ? maxdepth : 1; | ||
| for (int j = 0; j < maxd; ++j) { | ||
| int dep = (depth < 0) ? (j + 1) : depth; |
There was a problem hiding this comment.
L2526-2528 below will not work if depth = 0 . Probably that value of the parameter will never be passed, but with the following update such a crash can be avoided:
| int dep = (depth < 0) ? (j + 1) : depth; | |
| int dep = (depth <= 0) ? (j + 1) : depth; |
Altrernatively, one could set here above maxd = 0 if depth = 0
There was a problem hiding this comment.
Or (probably even simpler) use "0" as default value for depth, rather than "-1"
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
@cmsbuild Please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47042/43170 |
|
+1 Size: This PR adds an extra 48KB to repository Comparison SummarySummary:
|
|
+alca |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Update the macros to study the forward backward asymmetry in the correction factors
PR validation:
Use the macros to finalise 2024 correction factors of HCAL
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special