Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx360T Make a test code to find the area of HGCal cells through the method "cellArea" of HGCalDDConst #46886

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 6, 2024

PR description:

Make a test code to find the area of HGCal cells through the method "cellArea" of HGCalDDConst

PR validation:

Use this code to test the cell area evaluation

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46886/42920

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 6, 2024

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75fec1/43292/summary.html
COMMIT: 03f691f
CMSSW: CMSSW_15_0_X_2024-12-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46886/43292/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Moanwar
Copy link
Contributor

Moanwar commented Dec 6, 2024

+Upgrade

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 6, 2024

+geometry

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e9b58be into cms-sw:master Dec 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants