Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMSSW_14_0_X:Update HSCParticle object to be compatible with MiniAOD #46867

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

enibigir
Copy link
Contributor

@enibigir enibigir commented Dec 4, 2024

PR description:

This PR is a backport of PR#46840 already merged.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

A new Pull Request was created by @enibigir for CMSSW_14_0_X.

It involves the following packages:

  • AnalysisDataFormats/SUSYBSMObjects (analysis)

@cmsbuild, @tvami can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

cms-bot internal usage

@tvami
Copy link
Contributor

tvami commented Dec 4, 2024

backport of #46840

@tvami
Copy link
Contributor

tvami commented Dec 4, 2024

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Dec 4, 2024

I think it's ok to have the data format change, since we didnt produce any MC that would actually use this object

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e1cf88/43244/summary.html
COMMIT: faf8126
CMSSW: CMSSW_14_0_X_2024-12-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46867/43244/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tvami
Copy link
Contributor

tvami commented Dec 4, 2024

+analysis

@tvami
Copy link
Contributor

tvami commented Dec 4, 2024

@cmsbuild ping

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

hold
Will there be PRs to 14_1_X and 14_2_X? I don't see them.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@tvami
Copy link
Contributor

tvami commented Dec 9, 2024

14_1_X was for HI, right? This is not relevant for that.
14_2_X, hmm yeah maybe there it should be there

@enibigir
Copy link
Contributor Author

enibigir commented Dec 9, 2024

I have prepared backports for both 14_1_X and 14_2_X

@enibigir
Copy link
Contributor Author

enibigir commented Dec 9, 2024

@mandrenguyen @tvami

@mandrenguyen
Copy link
Contributor

unhold
Thank you @enibigir

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9a4b9e4 into cms-sw:CMSSW_14_0_X Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants