Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced allocations in ShiftedJetProducerT #46789

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Reduced allocations in ShiftedJetProducerT #46789

merged 4 commits into from
Nov 26, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Reduced allocations within jet correction uncertainties conditions
  • Improved ShiftedJetProducerT
    • reduced allocations
    • added fillDescriptions
    • modernized C++ syntax
    • updated to newer framework syntax
    • only update data derived from the EventSetup if the EventSetup data changes

PR validation:

Code compiles. A simple job using a prototype alloc monitor showed reduced amount of memory held from event to event.

NOTE: this should just be a refactoring so the PR tests should show no differences. If there are differences than debugging will be necessary.

@Dr15Jones
Hold member data by value in JetCorrectionUncertainty
f540081 
This avoids an unnecessary allocation and simplifies memory
management.
@Dr15Jones
Reduce allocations in SimpleJetCorrectionUncertainty
f6aae99 
- hold member data by value
- avoid using a temporary std::vector and use a span which skips
3 indicies.
@Dr15Jones
Modernize ShiftedJetProducerT
1a89dc2 
- reduced number of allocations
- added fillDescriptions
- moved to newer C++ syntax
- switched to newer framework syntax
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Nov 24, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 24, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46789/42772

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • CondFormats/JetMETObjects (db)
  • PhysicsTools/PatUtils (reconstruction, xpog)

@atpathak, @consuegs, @francescobrivio, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @perrotta can you please review it and eventually sign? Thanks.
@AlexDeMoor, @JanChyczynski, @Ming-Yan, @PonIlya, @Senphy, @ahinzmann, @andrzejnovak, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mmarionncern, @mmusich, @nhanvtran, @rappoccio, @rsreds, @schoef, @seemasharmafnal, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c586e/43030/summary.html
COMMIT: 1a89dc2
CMSSW: CMSSW_15_0_X_2024-11-24-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46789/43030/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 384
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3483318
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor Author

The differences in the PR test appear to be unrelated to this PR (they are from HGCal which is known to produce inconsistent results).

@jfernan2
Copy link
Contributor

+1

@hqucms
Copy link
Contributor

hqucms commented Nov 25, 2024

+1

@makortel makortel mentioned this pull request Nov 25, 2024
Closed
@Dr15Jones
Copy link
Contributor Author

please test

@hqucms @jfernan2 please resign as the only change was the removal of a comment.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46789/42796

@cmsbuild
Copy link
Contributor

Pull request #46789 was updated. @atpathak, @consuegs, @francescobrivio, @perrotta can you please check and sign again.

@perrotta
Copy link
Contributor

@hqucms @jfernan2 please resign as the only change was the removal of a comment.

Thank you @Dr15Jones !
By the way, those signatures were not reset by your update, so they do not need to resign. And I can also sign for db now, as I was already fine with the PR before the removal of the comment line

@perrotta
Copy link
Contributor

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c586e/43085/summary.html
COMMIT: c53a44d
CMSSW: CMSSW_15_0_X_2024-11-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46789/43085/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3f4d840 into cms-sw:master Nov 26, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the allocShiftedJetProducerT branch December 2, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
code-checks-approved db-approved fully-signed orp-approved reconstruction-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
6 participants
@Dr15Jones @cmsbuild @jfernan2 @hqucms @perrotta @mandrenguyen