Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BuildFiles, includes and comments #46657

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 11, 2024

PR description:

Fix BuildFiles, includes and comments.

No changes expected.

PR validation:

None.

@@ -34,4 +34,5 @@
<use name="alpaka"/>
<use name="eigen"/>
<use name="boost"/>
<use name="HeterogeneousCore/AlpakaInterface"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2024

cms-bot internal usage

@@ -1,4 +1,4 @@
<use name="alpaka"/>
<use name="rootcling"/>
<use name="FWCore/Utilities/" source_only="1"/>
<use name="HeterogeneousCore/AlpakaInterface" source_only="1"/>
<use name="HeterogeneousCore/AlpakaInterface"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This because source_only="1" does not propagate the module's external dependencies.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 11, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 11, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46657/42577

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • DataFormats/Portable (heterogeneous)
  • RecoTracker/PixelSeeding (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba0ea4/42723/summary.html
COMMIT: a630ad2
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46657/42723/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8ceb3f7 into cms-sw:master Nov 13, 2024
11 checks passed
@fwyzard fwyzard deleted the fix_buildfiles_and_includes branch November 13, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants