-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to new RNTuple version #46615
Conversation
RNTuple can now handle the std container in IsoDeposit.
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46615/42513
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @Moanwar, @antoniovagnerini, @bbilin, @ftorrresd, @hqucms, @jfernan2, @lviliani, @makortel, @mandrenguyen, @menglu21, @mkirsano, @rseidita, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
NOTE: This change affects nothing we presently do. It is only needed once we want to read/write the ROOT RNTuple format. |
As a test, I used a private branch I have with an RNTuple based Source and OutputModule with this change and was able to read/write AOD and miniAOD files. |
type -changes-dataformats The changes here do not impact present production system. |
+1 Size: This PR adds an extra 56KB to repository Comparison SummarySummary:
|
+1 |
+1
|
+Upgrade |
+1 |
ping @cms-sw/core-l2 @cms-sw/generators-l2 |
+core |
ping @cms-sw/generators-l2 |
ping @cms-sw/generators-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Code compiles.