-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx360D First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance #46565
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46565/42449 |
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@bsunanda can you add workflows for this new detector version in ? Then we can test it directly in this PR. |
@kpedro88 OK I shall do that. I wanted to discuss on the remaining overlaps |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46565/42451 |
Pull request #46565 was updated. @AdrianoDee, @Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please check and sign again. |
The new workflow is 32434.0 |
test parameters: |
+geometry |
+1 |
NB this will conflict with #46582 |
Given the amount of signatures needed and the good number of those already collected for #46582, I'd leave that go first. |
Although this PR was made earlier?
…________________________________
From: Adriano Di Florio ***@***.***>
Sent: 04 November 2024 15:39
To: cms-sw/cmssw ***@***.***>
Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***>
Subject: Re: [cms-sw/cmssw] Phase2-hgx360D First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance (PR #46565)
Given the amount of signatures needed and the good number of those already collected for #46582<#46582>, I'd leave that go first.
—
Reply to this email directly, view it on GitHub<#46565 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOTN53ICWARHGAX43VTZ65BWDAVCNFSM6AAAAABQ6CUF5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJUGI4DOMRTG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Apparenlty #46582 needs a rebase anyway. |
+pdmv |
Let's try to merge this PR, and avoid to merge something else. So that the big one can go. Thanks. |
Kindly ping @cms-sw/upgrade-l2 |
+Upgrade |
Since the big file is merged first, I am closing this PR and making a fresh one |
PR description:
The first attempt to make a Phase2 scenario 2026D116 with no overlaps with zero tolerance
PR validation:
Tested using overlap checking tools present in SimG4Core/PrintGeomInfo. The number of overlaps is reduced from 348 to 38. The remaining overlaps are all in EB for reflected Solids
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special