Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx360D First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance #46565

Closed
wants to merge 2 commits into from

Conversation

bsunanda
Copy link
Contributor

PR description:

The first attempt to make a Phase2 scenario 2026D116 with no overlaps with zero tolerance

PR validation:

Tested using overlap checking tools present in SimG4Core/PrintGeomInfo. The number of overlaps is reduced from 348 to 38. The remaining overlaps are all in EB for reflected Solids

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (upgrade, geometry)
  • Geometry/ForwardCommonData (geometry)
  • Geometry/MuonCommonData (geometry)
  • SimG4Core/PrintGeomInfo (simulation)

@Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @ptcox, @rovere, @sameasy, @slomeo, @vargasa, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

@bsunanda can you add workflows for this new detector version in

? Then we can test it directly in this PR.

@bsunanda
Copy link
Contributor Author

@kpedro88 OK I shall do that. I wanted to discuss on the remaining overlaps

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

The new workflow is 32434.0

@kpedro88
Copy link
Contributor

test parameters:
workflow = 32434.0

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 1, 2024

+geometry

@civanch
Copy link
Contributor

civanch commented Nov 3, 2024

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 3, 2024

NB this will conflict with #46582

@AdrianoDee
Copy link
Contributor

Given the amount of signatures needed and the good number of those already collected for #46582, I'd leave that go first.

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 4, 2024 via email

@AdrianoDee
Copy link
Contributor

Apparenlty #46582 needs a rebase anyway.

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

srimanob commented Nov 4, 2024

Let's try to merge this PR, and avoid to merge something else. So that the big one can go. Thanks.
FYI @cms-sw/orp-l2

@srimanob
Copy link
Contributor

srimanob commented Nov 4, 2024

Kindly ping @cms-sw/upgrade-l2

@Moanwar
Copy link
Contributor

Moanwar commented Nov 4, 2024

+Upgrade

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 6, 2024

Since the big file is merged first, I am closing this PR and making a fresh one

@bsunanda bsunanda closed this Nov 6, 2024
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Nov 6, 2024
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Nov 14, 2024
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Nov 21, 2024
cmsbuild added a commit that referenced this pull request Nov 25, 2024
Phase2-hgx360FX Attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 and #46610
tschuh pushed a commit to cms-L1TK/cmssw that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants