Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PbPb skims for 2024 data taking #46447

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

flodamas
Copy link
Contributor

PR description:

Update of the configuration of the PbPb skims in view of the 2024 HI run. The ZMM skim is replaced by the ZMu skimming code to avoid duplicates such that a unique skimmed dataset can be used for both Z boson physics analyses and muon tag-and-probe.

PR validation:

Unit tests passed successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_1_X for the HI run.

@cmsbuild cmsbuild changed the base branch from CMSSW_14_2_X to master October 18, 2024 18:21
@cmsbuild
Copy link
Contributor

@flodamas, CMSSW_14_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46447/42307

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @flodamas for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42313/summary.html
COMMIT: 7ded028
CMSSW: CMSSW_14_2_X_2024-10-20-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46447/42313/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566331
  • DQMHistoTests: Total failures: 453
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3565856
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor

Hi, I would like to make sure if the update is also available to ReReco 2023 Heavy ion data even in the future.

@mandrenguyen
Copy link
Contributor

Hi, I would like to make sure if the update is also available to ReReco 2023 Heavy ion data even in the future.

Hi @youyingli I'm not sure I understand the comment. These are prompt skims, we would not run them in a reprocessing.

@youyingli
Copy link
Contributor

Hi, I would like to make sure if the update is also available to ReReco 2023 Heavy ion data even in the future.

Hi @youyingli I'm not sure I understand the comment. These are prompt skims, we would not run them in a reprocessing.

OK, thanks. Just make sure if these skims will also join 2023 Heavy ion data reprocessing in the future. Now I understand.

@cms-sw/pdmv-l2, could you please sign it?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@AdrianoDee
Copy link
Contributor

(signed anyway, will sign again after the conflicts are solved)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46447 was updated. @cmsbuild can you please check and sign again.

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42514/summary.html
COMMIT: 1153f7c
CMSSW: CMSSW_14_2_X_2024-10-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42514/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42514/git-merge-result

RelVals

----- Begin Fatal Exception 31-Oct-2024 17:50:37 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_PAT_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file PhysicsTools/NanoAOD/data/el_BDTG_2022.weights.xml anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.023_RunZeroBias2022B


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 31-Oct-2024 17:50:40 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_PAT_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file PhysicsTools/NanoAOD/data/el_BDTG_2022.weights.xml anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.043_RunZeroBias2022C


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 31-Oct-2024 17:50:46 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_PAT_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file PhysicsTools/NanoAOD/data/el_BDTG_2022.weights.xml anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.063_RunZeroBias2022D


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 2500.0022500.002_NANOmc106Xul17v2/step2_NANOmc106Xul17v2.log
  • 2500.0012500.001_NANOmc106Xul16v2/step2_NANOmc106Xul16v2.log
  • 2500.0032500.003_NANOmc106Xul18v2/step2_NANOmc106Xul18v2.log
Expand to see more relval errors ...

@mandrenguyen
Copy link
Contributor

ignore tests-rejected with ib-failure
errors clearly unrelated to this PR

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e5f980b into cms-sw:master Oct 31, 2024
9 of 11 checks passed
@flodamas flodamas deleted the PbPbSkims2024_142X branch November 2, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants