Remove DeepTauID v2.1 from mini- and nanoAOD

[mbluj]

PR description:

As title says, this PR removes DeepTauID v2.1 from mini and nanoAOD as it is superseded by v2.5 and v2.1 is not supported by Tau POG for Run-3 (and Run-2+3) analyses.

PR validation:

Tested with wf. 13034.21 (TTbar_14TeV+2024PU_ProdLike) which is a good representative of mini+nano workflows involving DeepTauID production.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backports are not expected.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46063/41850

• There are other open Pull requests which might conflict with changes you have proposed:
  • File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): [NanoAOD] Add PF constituents for AK8 jets #46012
  • File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Adding PAIReDJet Table to NanoAOD #45207

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)
• PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

enable nano

[jfernan2]

please test

[cmsbuild]

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ecef8/41642/summary.html
COMMIT: eb36050
CMSSW: CMSSW_14_2_X_2024-09-19-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46063/41642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1582 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331020
• DQMHistoTests: Total failures: 2254
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328746
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -15.719999999999995 KiB( 43 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -1.383 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13234.0,... ): -0.671 KiB Physics/NanoAODDQM
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 329 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2036 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 55030
• DQMHistoTests: Total failures: 966
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 54064
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -11.611999999999998 KiB( 20 files compared)
• DQMHistoSizes: changed ( 2500.001,... ): -1.383 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.011,... ): -0.671 KiB Physics/NanoAODDQM
• Checked 102 log files, 58 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.821	2.841	-0.021 ( -0.7% )	3.10	3.10	-0.0%	6.681	6.037
2500.002	2.934	2.955	-0.021 ( -0.7% )	2.78	2.77	+0.4%	7.039	6.416
2500.003	2.879	2.901	-0.022 ( -0.8% )	2.91	2.89	+0.6%	7.010	6.391
2500.011	1.478	1.493	-0.015 ( -1.0% )	4.79	4.80	-0.2%	2.421	2.390
2500.012	1.941	1.959	-0.018 ( -0.9% )	2.91	2.91	-0.1%	2.604	2.533
2500.013	1.791	1.809	-0.018 ( -1.0% )	4.15	4.13	+0.7%	2.514	2.391
2500.021	0.022	0.022	0.000 ( +0.0% )	0.99	0.94	+5.5%	2.354	2.200
2500.022	0.022	0.022	0.000 ( +0.0% )	0.97	0.90	+7.2%	2.347	2.199
2500.023	0.022	0.022	0.000 ( +0.2% )	0.95	0.89	+6.3%	2.219	2.138
2500.024	0.022	0.022	0.000 ( +0.0% )	0.72	0.69	+4.5%	2.449	2.308
2500.031	0.035	0.035	0.000 ( +0.0% )	0.88	0.84	+5.2%	2.413	2.281
2500.032	0.036	0.036	0.000 ( +0.0% )	0.91	0.83	+9.8%	2.370	2.228
2500.033	0.037	0.037	0.000 ( +0.0% )	0.80	0.78	+3.0%	2.466	2.327
2500.034	0.036	0.036	0.000 ( +0.0% )	0.82	0.80	+3.1%	2.439	2.309
2500.101	2.635	2.660	-0.025 ( -1.0% )	9.02	8.88	+1.6%	6.949	6.298
2500.111	1.324	1.342	-0.017 ( -1.3% )	20.12	20.07	+0.3%	2.233	2.227
2500.112	1.730	1.749	-0.020 ( -1.1% )	15.53	15.01	+3.4%	2.313	1.803
2500.131	0.747	0.747	0.000 ( +0.0% )	18.51	18.26	+1.4%	1.522	1.416
2500.201	2.465	2.490	-0.025 ( -1.0% )	7.83	7.48	+4.7%	6.237	5.830
2500.211	1.592	1.612	-0.020 ( -1.3% )	17.89	17.17	+4.2%	2.280	1.823
2500.212	2.034	2.055	-0.020 ( -1.0% )	14.35	13.94	+3.0%	2.366	1.857
2500.221	2.003	2.003	0.000 ( +0.0% )	7.92	7.71	+2.7%	2.446	1.970
2500.222	3.195	3.222	-0.027 ( -0.9% )	7.72	7.44	+3.8%	2.537	2.063
2500.223	8.882	8.909	-0.027 ( -0.3% )	2.68	2.60	+3.2%	2.566	2.315
2500.224	5.652	5.680	-0.029 ( -0.5% )	0.60	0.60	+0.7%	2.597	2.385
2500.225	5.669	5.698	-0.029 ( -0.5% )	0.59	0.58	+2.4%	2.612	2.429
2500.226	2.957	2.988	-0.031 ( -1.0% )	7.69	7.34	+4.8%	2.535	2.297
2500.227	1.437	1.437	0.000 ( +0.0% )	11.92	11.70	+1.9%	1.433	1.321
2500.231	1.403	1.403	0.000 ( +0.0% )	14.32	13.57	+5.5%	2.185	1.935
2500.232	2.239	2.260	-0.020 ( -0.9% )	14.16	13.47	+5.1%	2.281	2.030
2500.233	4.687	4.707	-0.020 ( -0.4% )	4.31	4.06	+6.1%	2.298	2.019
2500.234	3.395	3.415	-0.020 ( -0.6% )	0.76	0.75	+2.2%	2.301	2.050
2500.235	3.406	3.426	-0.020 ( -0.6% )	0.75	0.74	+0.7%	2.332	2.110
2500.236	2.084	2.107	-0.023 ( -1.1% )	14.30	13.54	+5.7%	2.270	2.012
2500.237	1.016	1.016	0.000 ( +0.0% )	16.07	16.67	-3.6%	1.477	1.346
2500.241	9.404	9.404	0.000 ( +0.0% )	3.84	3.66	+4.9%	1.950	1.774
2500.242	10.331	10.331	0.000 ( +0.0% )	0.89	0.90	-0.9%	1.735	1.610
2500.243	2.712	2.712	0.000 ( +0.0% )	8.77	8.42	+4.1%	1.074	1.075
2500.244	485.976	485.976	0.000 ( +0.0% )	0.57	0.55	+4.7%	1.687	1.606
2500.245	823.202	823.202	0.000 ( +0.0% )	0.77	0.74	+4.0%	1.666	1.593
2500.901	1.777	1.777	0.000 ( +0.0% )	21.60	20.88	+3.4%	1.848	1.766
2500.902	1.626	1.626	0.000 ( +0.0% )	20.55	20.88	-1.6%	1.773	1.725
2500.911	13.995	13.995	0.000 ( +0.0% )	3.55	2.93	+21.0%	1.102	1.088
2500.912	0.310	0.729	-0.419 ( -57.5% )	1.27	1.29	-1.5%	0.979	0.974
2500.913	0.110	0.110	0.000 ( +0.0% )	1.17	1.11	+6.1%	0.981	0.979

[hqucms]

+1

[jfernan2]

Is it understood why the diff rate increases despite removing this TauID?

[mbluj]

Is it understood why the diff rate increases despite removing this TauID?

Hello, most of observed differences are caused by the DeepTauID v2.1 removal and is as expected; these differences are:

• changes in tauIDs embedded in slimmedTaus in miniAOD: removal of DeepTauID v2.1 results in reduced number of tauIDs and difference in their order,
• changes in Tau tables in nanoADO: removal of DeepTauID v2.1 related branches and some change in multiplicity of tau candidates as candidates which used to be selected uniquely with loosest WP of DeepTauID v2.1 are now rejected.

There are also some unrelated tracking differences (which then propagate to packed particles and flavour taggers) in mkFit wfs, e.g. 12834.7 - I do not know if these are expected, but are not related to this PR.

[hqucms]

Is it understood why the diff rate increases despite removing this TauID?

The rate is ev/s so increasing means faster :)

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1