Split ZVertexSoA in a run-time sized PortableMultiCollection #45887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45887/41639
|
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
fwyzard
force-pushed
the
ZVertexMultiLayout
branch
from
8721994 to
410ed35
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45887/41642
|
|
Pull request #45887 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
fwyzard
force-pushed
the
ZVertexMultiLayout
branch
from
410ed35 to
ccaaee8
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45887/41685
|
|
+heterogeneous |
|
+1 |
|
+hlt
|
|
kind ping to @cms-sw/dqm-l2 🙏🏻 |
|
+1
|
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This was referenced Sep 13, 2024
|
cross posting the following comment: Is there a failure related to this PR? |
Nothing has been reported since the PR was merged, and the IB GPU tests are clean (for the history that is visible). On the other hand, this doesn't prove much because the workflow that failed in #46686 (comment), 14949.402, is not tested in IBs. |
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Split
ZVertexSoAin two layouts, and wrap them in a multi-layout collection.Make the ZVertex SoA collections run-time sized, and replace the
ZVertexHost/ZVertexDevicetemplate classes inheriting fromPortableHostMultiCollection/PortableDeviceMultiCollectionwith type aliases.Remove versioning info from class description for dictionaries.
Port comments from the CUDA version.
The maximum number of vertices is now a configuration parameter of the
PixelVertexProducerAlpakaEDProducer, while all device-side checks now make use of the various SoA capacity.The maximum number of vertices is set to
256for Run 3512for Phase 232for heavy ionsThese values are probably conservative, and could be further reduced.
The tests use the legacy hard-coded values, taken from the old Run 3 defaults.
The documentation in
DataFormats/VertexSoA/README.mdis updated accordingly.PR validation:
Unit tests and workflow
12834.403pass.