Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificates handling to G2GainsValidator.py #45867

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 3, 2024

PR description:

The spirit of this PR is similar to #45779.
This PR adds providing certificates for curl requests done to https://cmsweb.cern.ch/t0wmadatasvc/prod/ from G2GainsValidator.py.
The paths to the certificate and the key are meant to be specified in X509_USER_CERT and X509_USER_KEY and can be automatically fetched by the user (when not available) via the option '-u' or '--user-mode'.
I am assuming they are available in the cms-bot test environment so I am not going to impose that mode when running tests.
I also profit of the PR to add a dedicated unit test: test_G2GainsValidator

PR validation:

scram b runtests_test_G2GainsValidator runs fine with this branch.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, to be backported to CMSSW_14_1_X and CMSSW_14_0_X for data-taking operations purposes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CondCore/SiStripPlugins (db)

@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @VinInn, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 3, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fed38f/41263/summary.html
COMMIT: c01d0d2
CMSSW: CMSSW_14_2_X_2024-09-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45867/41263/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328315
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328295
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Sep 4, 2024

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bc5cfae into cms-sw:master Sep 4, 2024
11 checks passed
@mmusich mmusich deleted the mm_G2GainsValidator_update branch September 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants