-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificates handling to G2GainsValidator.py
#45867
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45867/41620 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+db |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The spirit of this PR is similar to #45779.
This PR adds providing certificates for curl requests done to
https://cmsweb.cern.ch/t0wmadatasvc/prod/
fromG2GainsValidator.py
.The paths to the certificate and the key are meant to be specified in
X509_USER_CERT
andX509_USER_KEY
and can be automatically fetched by the user (when not available) via the option '-u' or '--user-mode'.I am assuming they are available in the cms-bot test environment so I am not going to impose that mode when running tests.
I also profit of the PR to add a dedicated unit test:
test_G2GainsValidator
PR validation:
scram b runtests_test_G2GainsValidator
runs fine with this branch.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, to be backported to CMSSW_14_1_X and CMSSW_14_0_X for data-taking operations purposes.