`TrackingRecHitsSoACollection`: early return `hostData` in `CopyHost::copyAsync()` when there aren't hits #45837

mmusich · 2024-08-29T20:59:07Z

PR description:

This PR is meant as a fix for #45834, and builds on top of the earlier fix #45743 for issue #45708.
In a nutshell, CopyHost::copyAsync() returns before the alpaka::memcpy call in TrackingRecHitsSoACollection if the size() of the input deviceData is null (i.e. there are no input hits).
Additionally protect CAHitNtupletGenerator by returning before launching kernels when there are less than 2 hits.

PR validation:

Multiple tests have been performed with this branch:

I tested successfully (on lxplus8-gpu):

the script at OneToManyAssoc assertion faillure in HLT menu in CMSSW_14_0_15 #45834 (comment) (standard FOG-like tests for pp)
the script at Runtime crash when forcing only pixel tracking+vertexing on serial_sync backend #45708 (comment) (hybrid GPU+CPU menu, HIon-like)
runTheMatrix.py --what upgrade -l 12861.402

Additionally, following the example at #45834 (comment) I I feed the "alpaka-migrated" menu from CMSHLT-3284 into the relval machinery via:

cmsrel CMSSW_14_0_15
cd CMSSW_14_0_15/src
cmsenv
git cms-addpkg HLTrigger/Configuration
git cms-addpkg Configuration/PyReleaseValidation
hltGetConfiguration /users/soohwan/HLT_140X/Alpaka/HIonV173/V10 \
   --globaltag auto:phase1_2024_realistic \
   --mc \
   --unprescale \
   --cff > "${CMSSW_BASE}"/src/HLTrigger/Configuration/python/HLT_User_cff.py
scram b -j 20

and then apply the following patch:

diff --git a/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py b/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
index 8a70a74aa0c..f9dc0a0397f 100644
--- a/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
+++ b/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
@@ -2865,7 +2865,7 @@ upgradeProperties[2017] = {
     '2022HI' : {
         'Geom' : 'DB:Extended',
         'GT':'auto:phase1_2022_realistic_hi',
-        'HLTmenu': '@fake2',
+        'HLTmenu': 'User',
         'Era':'Run3_pp_on_PbPb',
         'BeamSpot': 'DBrealistic',
         'ScenToRun' : ['GenSim','Digi','RecoNano','HARVESTNano','ALCA'],
@@ -2873,7 +2873,7 @@ upgradeProperties[2017] = {
     '2022HIRP' : {
         'Geom' : 'DB:Extended',
         'GT':'auto:phase1_2022_realistic_hi',
-        'HLTmenu': '@fake2',
+        'HLTmenu': 'User',
         'Era':'Run3_pp_on_PbPb_approxSiStripClusters',
         'BeamSpot': 'DBrealistic',
         'ScenToRun' : ['GenSim','Digi','RecoNano','HARVESTNano','ALCA'],
@@ -2881,7 +2881,7 @@ upgradeProperties[2017] = {
     '2023HI' : {
         'Geom' : 'DB:Extended',
         'GT':'auto:phase1_2023_realistic_hi',
-        'HLTmenu': '@fake2',
+        'HLTmenu': 'User',
         'Era':'Run3_pp_on_PbPb',
         'BeamSpot': 'DBrealistic',
         'ScenToRun' : ['GenSim','Digi','RecoNano','HARVESTNano','ALCA'],
@@ -2889,7 +2889,7 @@ upgradeProperties[2017] = {
     '2023HIRP' : {
         'Geom' : 'DB:Extended',
         'GT':'auto:phase1_2023_realistic_hi',
-        'HLTmenu': '@fake2',
+        'HLTmenu': 'User',
         'Era':'Run3_pp_on_PbPb_approxSiStripClusters',
         'BeamSpot': 'DBrealistic',
         'ScenToRun' : ['GenSim','Digi','RecoNano','HARVESTNano','ALCA'],

in a release that I have prepared with this and then finally run:

runTheMatrix.py --what upgrade -l 15261.0 --maxSteps 2 (neutrino gun input)
runTheMatrix.py --what upgrade -l 15224.0 --maxSteps 2 (TTbar input)

Both tests run fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will need to be backported down to CMSSW_14_0_X for data-taking purposes.

cmsbuild · 2024-08-29T20:59:28Z

cms-bot internal usage

DataFormats/TrackingRecHitSoA/interface/alpaka/TrackingRecHitsSoACollection.h

cmsbuild · 2024-08-29T21:02:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45837/41580

cmsbuild · 2024-08-29T21:02:42Z

A new Pull Request was created by @mmusich for master.

It involves the following packages:

DataFormats/TrackingRecHitSoA (reconstruction, heterogeneous)
RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2024-08-31T08:20:20Z

enable gpu

mmusich · 2024-08-31T08:23:04Z

test parameters:

workflows = 12861.402
relvals_opt = --what upgrade

mmusich · 2024-08-31T08:23:14Z

@cmsbuild, please test

cmsbuild · 2024-08-31T12:22:13Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-271d6a/41204/summary.html
COMMIT: d9eb4a3
CMSSW: CMSSW_14_2_X_2024-08-30-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45837/41204/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 183 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3450788
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3450765
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 201 log files, 173 edm output root files, 46 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 6
DQMHistoTests: Total histograms compared: 37044
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 37031
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
Checked 20 log files, 25 edm output root files, 6 DQM output files
TriggerResults: no differences found

mmusich · 2024-09-02T11:20:20Z

@cms-sw/reconstruction-l2 @cms-sw/heterogeneous-l2 can you have a look?
HLT would like to have this included in the next (patch-)release for HLT data-taking.

mmusich · 2024-09-02T11:20:25Z

urgent

… hits

cmsbuild · 2024-09-02T12:18:58Z

Pull request #45837 was updated. @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please check and sign again.

fwyzard · 2024-09-02T12:20:06Z

@cmsbuild please test

fwyzard · 2024-09-02T12:20:12Z

+heterogeneous

cmsbuild · 2024-09-02T17:59:21Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-271d6a/41221/summary.html
COMMIT: e7893f2
CMSSW: CMSSW_14_2_X_2024-09-02-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45837/41221/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3450788
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3450765
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 201 log files, 173 edm output root files, 46 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

You potentially removed 20 lines from the logs
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 6
DQMHistoTests: Total histograms compared: 37044
DQMHistoTests: Total failures: 664
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 36380
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
Checked 20 log files, 25 edm output root files, 6 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-09-03T08:35:05Z

+1

cmsbuild · 2024-09-03T08:35:28Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-09-03T09:52:07Z

+1

cmsbuild added this to the CMSSW_14_2_X milestone Aug 29, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending tracking labels Aug 29, 2024

mmusich commented Aug 29, 2024

View reviewed changes

DataFormats/TrackingRecHitSoA/interface/alpaka/TrackingRecHitsSoACollection.h Outdated Show resolved Hide resolved

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 29, 2024

cmsbuild added tests-started and removed tests-pending labels Aug 31, 2024

cmsbuild added tests-approved and removed tests-started labels Aug 31, 2024

cmsbuild added the urgent label Sep 2, 2024

TrackingRecHitsSoACollection: early return hostData when there aren't…

e7893f2

… hits

mmusich force-pushed the mm_fix_TrackingRecHitsSoACollection_14_2_X branch from d9eb4a3 to e7893f2 Compare September 2, 2024 12:14

cmsbuild added tests-pending and removed tests-approved code-checks-approved labels Sep 2, 2024

cmsbuild added the code-checks-approved label Sep 2, 2024

cmsbuild added tests-started heterogeneous-approved and removed tests-pending heterogeneous-pending labels Sep 2, 2024

This was referenced Sep 2, 2024

[14.1.X] TrackingRecHitsSoACollection: early return hostData in CopyHost::copyAsync() when there aren't hits #45857

Merged

[14.0.X] TrackingRecHitsSoACollection: early return hostData in CopyHost::copyAsync() when there aren't hits #45858

Merged

cmsbuild added tests-approved and removed tests-started labels Sep 2, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Sep 3, 2024

cmsbuild added orp-approved and removed orp-pending labels Sep 3, 2024

cmsbuild merged commit fdfb559 into cms-sw:master Sep 3, 2024
15 checks passed

mmusich deleted the mm_fix_TrackingRecHitsSoACollection_14_2_X branch September 3, 2024 10:08

This was referenced Sep 3, 2024

Refactoring of TICL EnergyRegression and PID model #45821

Merged

[TF] Update TF v2.16.1 (without libfft) cms-sw/cmsdist#9388

Closed

Fix issue with ZDCSimpleRecAlgo_Run3.cc #45868

Merged

makortel mentioned this pull request Sep 4, 2024

Assertion 'nHits >= 3' failed in RelVal 12861.0 #45871

Closed

cmsbuild mentioned this pull request Sep 5, 2024

[Do not merge] Testing TF 2.15 GPU cms-sw/cmsdist#9394

Closed

mmusich mentioned this pull request Sep 6, 2024

OneToManyAssoc assertion faillure in HLT menu in CMSSW_14_0_15 #45834

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`TrackingRecHitsSoACollection`: early return `hostData` in `CopyHost::copyAsync()` when there aren't hits #45837

`TrackingRecHitsSoACollection`: early return `hostData` in `CopyHost::copyAsync()` when there aren't hits #45837

mmusich commented Aug 29, 2024

cmsbuild commented Aug 29, 2024 •

edited

Loading

cmsbuild commented Aug 29, 2024

cmsbuild commented Aug 29, 2024

mmusich commented Aug 31, 2024

mmusich commented Aug 31, 2024

mmusich commented Aug 31, 2024

cmsbuild commented Aug 31, 2024

mmusich commented Sep 2, 2024

mmusich commented Sep 2, 2024

cmsbuild commented Sep 2, 2024

fwyzard commented Sep 2, 2024

fwyzard commented Sep 2, 2024

cmsbuild commented Sep 2, 2024

jfernan2 commented Sep 3, 2024

cmsbuild commented Sep 3, 2024

antoniovilela commented Sep 3, 2024

TrackingRecHitsSoACollection: early return hostData in CopyHost::copyAsync() when there aren't hits #45837

TrackingRecHitsSoACollection: early return hostData in CopyHost::copyAsync() when there aren't hits #45837

Conversation

mmusich commented Aug 29, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Aug 29, 2024 • edited Loading

cmsbuild commented Aug 29, 2024

cmsbuild commented Aug 29, 2024

mmusich commented Aug 31, 2024

mmusich commented Aug 31, 2024

mmusich commented Aug 31, 2024

cmsbuild commented Aug 31, 2024

Comparison Summary

GPU Comparison Summary

mmusich commented Sep 2, 2024

mmusich commented Sep 2, 2024

cmsbuild commented Sep 2, 2024

fwyzard commented Sep 2, 2024

fwyzard commented Sep 2, 2024

cmsbuild commented Sep 2, 2024

Comparison Summary

GPU Comparison Summary

jfernan2 commented Sep 3, 2024

cmsbuild commented Sep 3, 2024

antoniovilela commented Sep 3, 2024

`TrackingRecHitsSoACollection`: early return `hostData` in `CopyHost::copyAsync()` when there aren't hits #45837

`TrackingRecHitsSoACollection`: early return `hostData` in `CopyHost::copyAsync()` when there aren't hits #45837

cmsbuild commented Aug 29, 2024 •

edited

Loading