Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MiniAOD] Set Muon ID flags for PackedCandidates regardless of trackRef #45818

Merged

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR addresses issue #45814. The muon ID flags should be set regardless if the reco::PFCandidate has a trackRef or not. Type-1 MET correction will be more consistent between jets with reco::PFCandidate as its constituents and jets with pat::packedCandidate constituents.

PR validation:

  • passes the usual runTheMatrix test: runTheMatrix.py -i all --ibeos -l limited
  • passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction, xpog)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Aug 28, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5414b/41173/summary.html
COMMIT: f848b7d
CMSSW: CMSSW_14_2_X_2024-08-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45818/41173/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@hqucms
Copy link
Contributor

hqucms commented Aug 28, 2024

+1

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants