Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pagination of L1TUtmTriggerMenuPayloadInspector plots #45813

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 27, 2024

PR description:

The goal of this PR is to improve the graphical display of L1TMenu in the payload inspector when there are long lists of differences to be displayed.

PR validation:

Run the following script

#!/bin/bash

getPayloadData.py \
    --plugin pluginL1TUtmTriggerMenu_PayloadInspector \
    --plot plot_L1TUtmTriggerMenuDisplayAlgos \
    --tag L1Menu_Collisions2024_v1_3_0_xml \
    --input_params "{}" \
    --time_type Run \
    --iovs '{"start_iov": "1", "end_iov": "1"}' \
    --db Prod \
    --test ;

getPayloadData.py \
    --plugin pluginL1TUtmTriggerMenu_PayloadInspector \
    --plot plot_L1TUtmTriggerMenu_CompareAlgosTwoTags \
    --tag L1Menu_CollisionsPPRef2024_v0_0_1_xml \
    --input_params "{}" \
    --tagtwo L1Menu_Collisions2024_v1_3_0_xml \
    --time_type Run \

    --iovs '{"start_iov": "1", "end_iov": "1"}' \
    --iovstwo '{"start_iov": "1", "end_iov": "1"}' \
    --db Prod \
    --test ;

and obtained the following plots:

  • in release (as is)

eyJwbG90cyI6MiwicGxvdDEiOnsidGFnIjoiTDFNZW51X0NvbGxpc2lvbnNQUFJlZjIwMjNfdjFfMV8yX3htbCIsInBsb3QiOiJwbG90X0wxVFV0bVRyaWdnZXJNZW51X0NvbXBhcmVBbGdvc1R3b1RhZ3MiLCJwbHVnaW4iOiJwbHVnaW5MMVRVdG1UcmlnZ2VyTWVudV9QYXlsb2FkSW5zcGVjdG9yIiwidHlwZSI6IkltYWdlIiwiaW

  • with this branch:

3d39a948-4ea2-4403-bf1d-a54655bf9530

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CondCore/L1TPlugins (l1, db)

@aloeliger, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @missirol, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 28, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-434862/41169/summary.html
COMMIT: b1ca820
CMSSW: CMSSW_14_2_X_2024-08-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45813/41169/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+db

@mmusich
Copy link
Contributor Author

mmusich commented Aug 31, 2024

@cms-sw/l1-l2 please consider signing this purely technical PR

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dc5438a into cms-sw:master Sep 3, 2024
11 checks passed
@mmusich mmusich deleted the mm_improvePagination_L1TPI branch September 3, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants