-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better automatic handling of default 2026 geometry #45796
better automatic handling of default 2026 geometry #45796
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45796/41533 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test paramerters:
|
@cmsbuild, please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+Upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
@srimanob now that this PR is moved to |
Hi Marco, |
+1 |
PR description:
This is a follow-up to #45764, in order to enforce that the the "default" 2026 geometry is taken from one unique place (in this case:
Configuration/Geometry/python/defaultPhase2ConditionsEra_cff.py
).PR validation:
Checked out the following packages
in which the default geometry is used and check that all the unit tests run fine with:
scram b runtests
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A