-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] Add certificates handling to Tier0Handler #45780
Conversation
A new Pull Request was created by @JanChyczynski for CMSSW_14_0_X. It involves the following packages:
@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
5514851
to
ba3f99b
Compare
Pull request #45780 was updated. @cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please check and sign again. |
backport of #45779 |
@JanChyczynski please update this PR as you did for its master and 14_1_X versions |
Allow overriding T0 api url by TIER0_API_URL env variable on retry provie both proxy and cert
ba3f99b
to
8e62041
Compare
Pull request #45780 was updated. @cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please check and sign again. |
Updated, ready for the tests @perrotta |
please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
@perrotta @mandrenguyen Can you take a look and sign? I ping you mandrenguyen 'cause you've signed the main PR so maybe you can sign the backport too |
I only sign after everyone else does. @perrotta can you have a look please? |
+db
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds providing certificates for curl requests done to
https://cmsweb.cern.ch/t0wmadatasvc/prod/
.The paths to the certificate and the key are meant to be specified in
X509_USER_CERT
andX509_USER_KEY
.The certs became obligatory for accessing this API after migration of cmsweb from CC7 and this functionality is required by the conddb command and some O2Os (EcalLaser_prompt_run3, SiStripDetVOff_prompt, possibly also EcalLaser_prompt_hlt, ESGain_prompt, SIntercalibConstants_prompt, SRecHitRatioCuts_prompt, STimeSampleWeights_prompt)
The PR also introduces a way of overriding the hardcoded T0 API URL by setting the TIER0_API_URL env variable (eg. for test purposes).
PR validation:
Tested by running
python3 tier0.py
which is running the test for it.Backport
This is the backport to CMSSW_14_0_X of the main PR: #45779
FYI @perrotta @francescobrivio @PonIlya