Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use C++ concepts in monitor_file_utilities #45773

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Constrained types to be integral

PR validation:

Code compiles.

Constrained types to be integral
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Services (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fwyzard, @makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0883cd/41081/summary.html
COMMIT: 6b3be9e
CMSSW: CMSSW_14_1_X_2024-08-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45773/41081/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2024.1060052024.106005_RunMuonEG2024C_50k/step1_dasquery.log
  • 2024.1070052024.107005_RunNoBPTX2024C_50k/step1_dasquery.log
  • 2024.2040052024.204005_RunJetMET02024D_50k/step1_dasquery.log
Expand to see more relval errors ...

Comparison Summary

Summary:

@makortel
Copy link
Contributor

+core

@makortel
Copy link
Contributor

ignore tests-rejected with ib-failure

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8d0e1da into cms-sw:master Aug 23, 2024
10 of 11 checks passed
@Dr15Jones Dr15Jones deleted the concepts_monitor_file_utilities branch September 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants