Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] HCAL DQM Online Histogram for Bad Quality Events #45750

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

denizsun
Copy link

Bad Quality Events histogram and BadCapID rotation histogram

PR description:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 20, 2024

A new Pull Request was created by @denizsun for CMSSW_14_0_X.

It involves the following packages:

  • DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 20, 2024

cms-bot internal usage

@nothingface0
Copy link
Contributor

backport of #45571

@nothingface0
Copy link
Contributor

@denizsun Maybe a more appropriate title for the PR would be [14_0_X] HCAL DQM Online Histogram for Bad Quality Events, for consistency with the main PR.

@tjavaid
Copy link

tjavaid commented Aug 20, 2024

please test

@denizsun denizsun changed the title Change from mod60 to mod10 for Bad Quality Events histogram and Bad C… [14_0_X] HCAL DQM Online Histogram for Bad Quality Aug 20, 2024
@denizsun
Copy link
Author

@denizsun Maybe a more appropriate title for the PR would be [14_0_X] HCAL DQM Online Histogram for Bad Quality Events, for consistency with the main PR.

@nothingface0 thanks for the suggestion title! done.

@denizsun denizsun changed the title [14_0_X] HCAL DQM Online Histogram for Bad Quality [14_0_X] HCAL DQM Online Histogram for Bad Quality Events Aug 20, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb0d01/41037/summary.html
COMMIT: d34dfe7
CMSSW: CMSSW_14_0_X_2024-08-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45750/41037/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Aug 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6277012 into cms-sw:CMSSW_14_0_X Sep 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants