[14.0.X] initialise phiBinner in device-to-host copy of TrackingRecHitsSoACollection<TrackerTraits>

[mmusich]

backport of #45743

PR description:

Originally as missirol@62620da
This PR is meant as a fix for #45708.
Fix to the device-to-host copy of TrackingRecHitsSoACollection<TrackerTraits>, in order to initialise the phiBinner data member on the host side.

A more complete explanation of the issue is provided by @makortel in #45708 (comment)

PR validation:

Executed the following script:

#!/bin/bash

[ $# -ge 1 ] || exit 1

hltLabel=hlt
outDir="${1}"

[ ! -d "${outDir}" ] || exit 1

mkdir -p "${outDir}"
cd "${outDir}"

hltGetConfiguration /dev/CMSSW_14_0_0/GRun/V173 \
  --globaltag 140X_dataRun3_HLT_v3 \
  --data \
  --no-prescale \
  --output none \
  --max-events -1 \
  --paths MC_*Tracking* \
  --input root://eoscms.cern.ch//eos/cms/store/group/tsg/STEAM/validations/GPUVsCPU/240814/raw_pickevents.root \
  > "${hltLabel}".py

cat <<@EOF >> "${hltLabel}".py
process.options.numberOfThreads = 1
process.options.numberOfStreams = 0
process.options.wantSummary = True

for foo in ['HLTAnalyzerEndpath', 'dqmOutput', 'MessageLogger']:
    if hasattr(process, foo):
        process.__delattr__(foo)

process.load('FWCore.MessageLogger.MessageLogger_cfi')

#process.options.accelerators = ['cpu']

#process.hltEcalDigisSoA.alpaka.backend = 'serial_sync'
#process.hltEcalUncalibRecHitSoA.alpaka.backend = 'serial_sync'
#process.hltHbheRecoSoA.alpaka.backend = 'serial_sync'
#process.hltParticleFlowRecHitHBHESoA.alpaka.backend = 'serial_sync'
#process.hltParticleFlowClusterHBHESoA.alpaka.backend = 'serial_sync'
#process.hltOnlineBeamSpotDevice.alpaka.backend = 'serial_sync'
#process.hltSiPixelClustersSoA.alpaka.backend = 'serial_sync'
#process.hltSiPixelRecHitsSoA.alpaka.backend = 'serial_sync'
process.hltPixelTracksSoA.alpaka.backend = 'serial_sync'
process.hltPixelVerticesSoA.alpaka.backend = 'serial_sync'
@EOF

CUDA_LAUNCH_BLOCKING=1 \
cmsRun "${hltLabel}".py &> "${hltLabel}".log

(originally from @missirol - thanks!) and verified that with this patch (N.B. only after having run git cms-checkdeps -a ) it runs, whereas it failed in a plain CMSSW_14_0_14_MULTIARCHS.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #45743 in order to use it for building the 2024 HIon HLT menu (see CMSHLT-3284 for more details).

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• DataFormats/TrackingRecHitSoA (heterogeneous, reconstruction)

@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @VourMa, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from initialise phiBinner in device-to-host copy of TrackingRecHitsSoACollection<TrackerTraits> #45743

[cmsbuild]

cms-bot internal usage

[mmusich]

type bug-fix

[mmusich]

enable gpu

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159c66/41018/summary.html
COMMIT: d50e7b0
CMSSW: CMSSW_14_0_X_2024-08-19-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45744/41018/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 89 lines from the logs
• Reco comparison results: 52 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3449742
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3449719
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 6
• DQMHistoTests: Total histograms compared: 37022
• DQMHistoTests: Total failures: 84
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 36938
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
• Checked 20 log files, 25 edm output root files, 6 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[mmusich]

@cms-sw/heterogeneous-l2 I see there is still discussion on this topic at #45708 (comment). In the meanwhile the master version of this PR (#45743) was already merged. Is there any action item left here, or can we merge this as-is?

[fwyzard]

+heterogeneous

Let's go ahead as is, and follow up afterwards.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

type hlt-int

[mmusich]

@cms-sw/orp-l2 can this be merged? We need this for the next 14.0.x (we'll request it at the next ORP meeting).

[mandrenguyen]

+1

[mmusich]

This PR is the culprit of #45834