Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pixel residuals monitoring at HLT #45739

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 18, 2024

PR description:

Title says it all, to provide pixel track residuals monitoring at the HLT during data-taking operations.

PR validation:

Run a 2024 workflow including a non trivial HLT step (via runTheMatrix.py -l 12834.0 -t 4 -j 8 --ibeos) and inspected the resulting DQM file. I've found the newly added monitoring elements filled.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to CMSSW_14_0_X for 2024 data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mtosi, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 18, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09879f/41002/summary.html
COMMIT: b9a1a9a
CMSSW: CMSSW_14_1_X_2024-08-18-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45739/41002/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422510
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3422444
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2318.5620000000004 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 371.617 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 139.001,... ): 44.430 KiB HLT/Pixel
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Aug 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Aug 19, 2024

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

… clean-up of SiPixelPhase1ResidualsExtra plugin
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45739 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09879f/41015/summary.html
COMMIT: 0993450
CMSSW: CMSSW_14_1_X_2024-08-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45739/41015/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422510
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3422487
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2304.456 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 369.266 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 139.001,... ): 44.430 KiB HLT/Pixel
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 19, 2024

unhold

@cmsbuild cmsbuild removed the hold label Aug 19, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Aug 19, 2024

pixel residuals at HLT plots are now nicely filled (see e.g. https://tinyurl.com/293tjdo3)

@mmusich
Copy link
Contributor Author

mmusich commented Aug 20, 2024

@cms-sw/dqm-l2 you already signed this at #45739 (comment), can you sign again?
The last push fixed a limitation in the previous implementation that made SiPixelPhase1ResidualsExtra fetch the input ME-s from the offline reconstruction and not from the HLT one.
It would be great to have the backport of this (#45746) included in the next Tier0 release.
Thank you!

@tjavaid
Copy link

tjavaid commented Aug 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 96fbe75 into cms-sw:master Aug 21, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_pixelResAtHLT branch August 21, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants