Fix for L1TMuonGlobalParams_PayloadInspector

[mmusich]

PR description:

As pointed out in #45438 (comment), the code implemented with #45438 had some error that need to be fixed.

PR validation:

Relies on the augmented unit tests at CondCore/L1TPlugins/test/testL1TObjectsPayloadInspector.cpp

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45738/41386

• There are other open Pull requests which might conflict with changes you have proposed:
  • File CondCore/L1TPlugins/plugins/BuildFile.xml modified in PR(s): Fix for L1TMuonGlobalParams_PayloadInspector #45737
  • File CondCore/L1TPlugins/plugins/L1TMuonGlobalParams_PayloadInspector.cc modified in PR(s): Fix for L1TMuonGlobalParams_PayloadInspector #45737

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• CondCore/L1TPlugins (l1, db)

@aloeliger, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @missirol, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f5934/41001/summary.html
COMMIT: bd92c25
CMSSW: CMSSW_14_1_X_2024-08-18-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45738/41001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 180 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3422510
• DQMHistoTests: Total failures: 1579
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3420911
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Unit test ends successfully
• Differences in wf 29634.911 are unrelated, see Non-reproducibility in 29634.911 #45505

[mmusich]

@cms-sw/l1-l2 please sign.

[aloeliger]

+l1

• @mmusich, apologies, just got back from vacation this morning.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

type bug-fix

[antoniovilela]

+1