[GCC13] Avoid Wdangling-reference in GenericTriggerEventFlag

[iarspider]

PR description:

In GCC13 IB, the following warning is emitted:

src/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc: In member function 'void GenericTriggerEventFlag::initRun(const edm::Run&, const edm::EventSetup&)':
  src/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc:213:30: warning: possibly dangling reference to a temporary [-Wdangling-reference]
   213 |       L1GtTriggerMenu const& l1GtTriggerMenu = setup.get<L1GtTriggerMenuRcd>().get(l1GtTriggerMenuToken_);
      |                              ^~~~~~~~~~~~~~~
src/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc:213:83: note: the temporary was destroyed at the end of the full expression 'edm::EventSetup::get() const [with T = L1GtTriggerMenuRcd]().L1GtTriggerMenuRcd::<anonymous>.edm::eventsetup::DependentRecordImplementation<L1GtTriggerMenuRcd, edm::mpl::Vector<L1GtStableParametersRcd, L1TriggerKeyListRcd, L1TriggerKeyRcd> >::<anonymous>.edm::eventsetup::EventSetupRecordImplementation<L1GtTriggerMenuRcd>::get<L1GtTriggerMenu>(((GenericTriggerEventFlag*)this)->GenericTriggerEventFlag::l1GtTriggerMenuToken_)'
  213 |       L1GtTriggerMenu const& l1GtTriggerMenu = setup.get<L1GtTriggerMenuRcd>().get(l1GtTriggerMenuToken_);
      |                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45733/41374

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45733/41374/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45733/41374/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45733/41375

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• CommonTools/TriggerUtils (hlt, l1)

@Martin-Grunewald, @aloeliger, @cmsbuild, @epalencia, @mmusich can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for el9_amd64_gcc13

[mmusich]

+hlt

• seems trivial in any case

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ded74/40999/summary.html
COMMIT: 6778425
CMSSW: CMSSW_14_1_X_2024-08-16-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45733/40999/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 264 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 61768 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3422510
• DQMHistoTests: Total failures: 364292
• DQMHistoTests: Total nulls: 373
• DQMHistoTests: Total successes: 3057825
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 5.620999999999999 KiB( 44 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): 2.776 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): 0.234 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.719 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): 2.702 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 8.0 ): -0.262 KiB SiStrip/MechanicalView
• Checked 196 log files, 165 edm output root files, 45 DQM output files

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1