[GCC13][AlCa] Avoid Wdangling-reference in SiPhase2OuterTrackerFakeLorentzAngleESSource #45730

iarspider · 2024-08-17T10:13:05Z

PR description:

In GCC13 IB, complier complains about dangling reference to a temporary:

src/CalibTracker/SiPhase2TrackerESProducers/plugins/SiPhase2OuterTrackerFakeLorentzAngleESSource.cc: In member function 'virtual std::unique_ptr<SiPhase2OuterTrackerLorentzAngle> SiPhase2OuterTrackerFakeLorentzAngleESSource::produceOTLA(const SiPhase2OuterTrackerLorentzAngleRcd&)':
  src/CalibTracker/SiPhase2TrackerESProducers/plugins/SiPhase2OuterTrackerFakeLorentzAngleESSource.cc:72:15: warning: possibly dangling reference to a temporary [-Wdangling-reference]
    72 |   const auto& geomDet = rcd.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
      |               ^~~~~~~
src/CalibTracker/SiPhase2TrackerESProducers/plugins/SiPhase2OuterTrackerFakeLorentzAngleESSource.cc:72:64: note: the temporary was destroyed at the end of the full expression 'edm::eventsetup::DependentRecordImplementation<RecordT, ListT>::getRecord() const [with DepRecordT = TrackerTopologyRcd; RecordT = SiPhase2OuterTrackerLorentzAngleRcd; ListT = edm::mpl::Vector<TrackerTopologyRcd>]().TrackerTopologyRcd::<anonymous>.edm::eventsetup::DependentRecordImplementation<TrackerTopologyRcd, edm::mpl::Vector<IdealGeometryRecord, PTrackerParametersRcd> >::get<GeometricDet, IdealGeometryRecord>(((SiPhase2OuterTrackerFakeLorentzAngleESSource*)this)->SiPhase2OuterTrackerFakeLorentzAngleESSource::m_geomDetToken)'
   72 |   const auto& geomDet = rcd.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
src/CalibTracker/SiPhase2TrackerESProducers/plugins/SiPhase2OuterTrackerFakeLorentzAngleESSource.cc: In member function 'virtual std::unique_ptr<SiPhase2OuterTrackerLorentzAngle> SiPhase2OuterTrackerFakeLorentzAngleESSource::produceOTSimLA(const SiPhase2OuterTrackerLorentzAngleSimRcd&)':
  src/CalibTracker/SiPhase2TrackerESProducers/plugins/SiPhase2OuterTrackerFakeLorentzAngleESSource.cc:78:15: warning: possibly dangling reference to a temporary [-Wdangling-reference]
    78 |   const auto& geomDet = rcd.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
      |               ^~~~~~~
src/CalibTracker/SiPhase2TrackerESProducers/plugins/SiPhase2OuterTrackerFakeLorentzAngleESSource.cc:78:64: note: the temporary was destroyed at the end of the full expression 'edm::eventsetup::DependentRecordImplementation<RecordT, ListT>::getRecord() const [with DepRecordT = TrackerTopologyRcd; RecordT = SiPhase2OuterTrackerLorentzAngleSimRcd; ListT = edm::mpl::Vector<TrackerTopologyRcd>]().TrackerTopologyRcd::<anonymous>.edm::eventsetup::DependentRecordImplementation<TrackerTopologyRcd, edm::mpl::Vector<IdealGeometryRecord, PTrackerParametersRcd> >::get<GeometricDet, IdealGeometryRecord>(((SiPhase2OuterTrackerFakeLorentzAngleESSource*)this)->SiPhase2OuterTrackerFakeLorentzAngleESSource::m_geomDetToken)'
   78 |   const auto& geomDet = rcd.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

Previously this warning was fixed by removing reference. However I think geomDet is not cheap to copy, so I opted for explicitly storing result of getRecord call.

PR validation:

Bot tests

…ngleESSource

cmsbuild · 2024-08-17T10:13:30Z

cms-bot internal usage

cmsbuild · 2024-08-17T10:15:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45730/41371

cmsbuild · 2024-08-17T10:15:29Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

CalibTracker/SiPhase2TrackerESProducers (upgrade, alca)

@cmsbuild, @consuegs, @perrotta, @saumyaphor4252, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

iarspider · 2024-08-17T10:17:02Z

please test for el9_amd64_gcc13

iarspider · 2024-08-17T10:17:45Z

please test

cmsbuild · 2024-08-17T13:35:25Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8304bf/40985/summary.html
COMMIT: fc10435
CMSSW: CMSSW_14_1_X_2024-08-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45730/40985/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 181 lines from the logs
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3422510
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3422489
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 196 log files, 165 edm output root files, 45 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-08-18T04:57:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8304bf/40983/summary.html
COMMIT: fc10435
CMSSW: CMSSW_14_1_X_2024-08-16-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45730/40983/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 262 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 61768 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3422510
DQMHistoTests: Total failures: 364289
DQMHistoTests: Total nulls: 373
DQMHistoTests: Total successes: 3057828
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 5.620999999999999 KiB( 44 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): 2.776 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): 0.234 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.719 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): 2.702 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -0.262 KiB SiStrip/MechanicalView
Checked 196 log files, 165 edm output root files, 45 DQM output files

perrotta · 2024-08-18T07:32:49Z

+alca

srimanob · 2024-08-20T20:12:54Z

+Upgrade

cmsbuild · 2024-09-01T02:00:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8304bf/41203/summary.html
COMMIT: 5588051
CMSSW: CMSSW_14_2_X_2024-08-30-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45730/41203/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 247 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 58095 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328315
DQMHistoTests: Total failures: 496306
DQMHistoTests: Total nulls: 317
DQMHistoTests: Total successes: 2831672
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 5.620999999999999 KiB( 43 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): 2.776 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): 0.234 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.719 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): 2.702 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -0.262 KiB SiStrip/MechanicalView
Checked 193 log files, 163 edm output root files, 44 DQM output files

perrotta · 2024-09-01T17:38:01Z

please test

cmsbuild · 2024-09-01T21:37:08Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8304bf/41210/summary.html
COMMIT: 5588051
CMSSW: CMSSW_14_2_X_2024-09-01-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45730/41210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 85 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328315
DQMHistoTests: Total failures: 4865
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3323430
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

perrotta · 2024-09-01T21:51:57Z

+1

srimanob · 2024-09-02T12:25:35Z

+Upgrade

Technical PR.

makortel · 2024-09-03T14:33:46Z

+core

cmsbuild · 2024-09-03T14:34:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-09-04T12:12:37Z

+1

[GCC13] Avoid Wdangling-reference in SiPhase2OuterTrackerFakeLorentzA…

fc10435

…ngleESSource

cmsbuild added this to the CMSSW_14_1_X milestone Aug 17, 2024

cmsbuild added alca-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending trk labels Aug 17, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 17, 2024

cmsbuild added tests-started and removed tests-pending labels Aug 17, 2024

cmsbuild added tests-approved and removed tests-started labels Aug 17, 2024

cmsbuild added alca-approved and removed alca-pending labels Aug 18, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Aug 20, 2024

cmsbuild added the tests-started label Aug 31, 2024

cmsbuild added tests-approved and removed tests-started labels Sep 1, 2024

cmsbuild added tests-started and removed tests-approved labels Sep 1, 2024

cmsbuild added tests-approved and removed tests-started labels Sep 1, 2024

cmsbuild added alca-approved db-approved and removed alca-pending db-pending labels Sep 1, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 2, 2024

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Sep 3, 2024

cmsbuild added orp-approved and removed orp-pending labels Sep 4, 2024

cmsbuild merged commit 62a1f50 into cms-sw:master Sep 4, 2024
18 checks passed

This was referenced Sep 4, 2024

Issue7955 type first spec 2 cms-sw/root#208

Closed

[Do not merge] Testing TF 2.15 GPU cms-sw/cmsdist#9394

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GCC13][AlCa] Avoid Wdangling-reference in SiPhase2OuterTrackerFakeLorentzAngleESSource #45730

[GCC13][AlCa] Avoid Wdangling-reference in SiPhase2OuterTrackerFakeLorentzAngleESSource #45730

iarspider commented Aug 17, 2024

cmsbuild commented Aug 17, 2024 •

edited

Loading

cmsbuild commented Aug 17, 2024

cmsbuild commented Aug 17, 2024

iarspider commented Aug 17, 2024

iarspider commented Aug 17, 2024

cmsbuild commented Aug 17, 2024

cmsbuild commented Aug 18, 2024

perrotta commented Aug 18, 2024

srimanob commented Aug 20, 2024

cmsbuild commented Sep 1, 2024

perrotta commented Sep 1, 2024

cmsbuild commented Sep 1, 2024

perrotta commented Sep 1, 2024

srimanob commented Sep 2, 2024

makortel commented Sep 3, 2024

cmsbuild commented Sep 3, 2024

mandrenguyen commented Sep 4, 2024

[GCC13][AlCa] Avoid Wdangling-reference in SiPhase2OuterTrackerFakeLorentzAngleESSource #45730

[GCC13][AlCa] Avoid Wdangling-reference in SiPhase2OuterTrackerFakeLorentzAngleESSource #45730

Conversation

iarspider commented Aug 17, 2024

PR description:

PR validation:

cmsbuild commented Aug 17, 2024 • edited Loading

cmsbuild commented Aug 17, 2024

cmsbuild commented Aug 17, 2024

iarspider commented Aug 17, 2024

iarspider commented Aug 17, 2024

cmsbuild commented Aug 17, 2024

Comparison Summary

cmsbuild commented Aug 18, 2024

Comparison Summary

perrotta commented Aug 18, 2024

srimanob commented Aug 20, 2024

cmsbuild commented Sep 1, 2024

Comparison Summary

perrotta commented Sep 1, 2024

cmsbuild commented Sep 1, 2024

Comparison Summary

perrotta commented Sep 1, 2024

srimanob commented Sep 2, 2024

makortel commented Sep 3, 2024

cmsbuild commented Sep 3, 2024

mandrenguyen commented Sep 4, 2024

cmsbuild commented Aug 17, 2024 •

edited

Loading