Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation for RPC hit reconstruction (backport of #45626, 14_0_X) #45711

Conversation

slowmoyang
Copy link
Contributor

PR description:

This PR drops plots that are no longer used in the release validation procedure for RPC hit reconstruction. The PR also simplifies the directory path where plots related to RPC hit reconstruction are stored.

@jhgoh @mileva @mrcthiel

PR validation:

The changes were reviewed in the last RPC DPG meeting. The PR has been tested with runTheMatrix.py -w upgrade -l 12811.0 with CMSSW_14_0_X_2024-08-12-2300

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #45626. This backport aims to improve upcoming RPC relval tasks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 16, 2024

A new Pull Request was created by @slowmoyang for CMSSW_14_0_X.

It involves the following packages:

  • Validation/RPCRecHits (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@JanFSchulte, @jhgoh, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 16, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Aug 19, 2024

backport of #45626

@tjavaid
Copy link

tjavaid commented Aug 19, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-987b30/41006/summary.html
COMMIT: f489d68
CMSSW: CMSSW_14_0_X_2024-08-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45711/41006/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 107 lines to the logs
  • Reco comparison results: 121 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342870
  • DQMHistoTests: Total failures: 2606
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3340244
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -55.525000000000034 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -2.221 KiB RPC/RPCRecHitV
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Aug 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

type rpc

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 21bf2f1 into cms-sw:CMSSW_14_0_X Aug 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants