Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable testTorchSimpleDnn for non-amd64 architectures #45688

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Disable testTorchSimpleDnn for non-amd64 architectures to fix test failing for aarch IBs: log

Running .cmd: apptainer exec -B /pool/condor/dir_1590998/jenkins/workspace/ib-run-qa/CMSSW_14_1_X_2024-08-11-0000  /cvmfs/unpacked.cern.ch/registry.hub.docker.com/cmsml/cmsml:3.11  python /pool/condor/dir_1590998/jenkins/workspace/ib-run-qa/CMSSW_14_1_X_2024-08-11-0000/src/PhysicsTools/PyTorch/test/create_simple_dnn.py /pool/condor/dir_1590998/jenkins/workspace/ib-run-qa/CMSSW_14_1_X_2024-08-11-0000/test/el8_aarch64_gcc12/ac19-74b6-90a1-cdc3
FATAL:   image targets 'amd64', cannot run on 'arm64'

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for el8_aarch64_gcc12

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45688/41245

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • PhysicsTools/PyTorch (ml)

@valsdav, @y19y19 can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca7c78/40869/summary.html
COMMIT: cec18ab
CMSSW: CMSSW_14_1_X_2024-08-11-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45688/40869/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca7c78/40868/summary.html
COMMIT: cec18ab
CMSSW: CMSSW_14_1_X_2024-08-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45688/40868/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422822
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3422796
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@iarspider
Copy link
Contributor Author

@cms-sw/ml-l2 gentle ping.

@valsdav
Copy link
Contributor

valsdav commented Aug 19, 2024

Thanks for the hotfix!
Instead of generating the model file on-the-fly with the apptainer image, we can alternatively store it directly.

@valsdav
Copy link
Contributor

valsdav commented Aug 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c96c622 into cms-sw:master Aug 19, 2024
17 checks passed
@iarspider iarspider deleted the testTorchSimpleDnn-only-amd64 branch August 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants