Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD Validation: add multiplicity and weight histograms #45680

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Aug 9, 2024

PR description:

Minimal addition to the Primary4DVertexValidation class to monitor the multiplicity and weight distribution of tracks associated to reconstructed vertices correctly matched to simulated ones.

PR validation:

Code runs and produces the expected output.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 9, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-151d47/40849/summary.html
COMMIT: 25c03a0
CMSSW: CMSSW_14_1_X_2024-08-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45680/40849/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 91 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422822
  • DQMHistoTests: Total failures: 2464
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3420338
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 11.242 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 1.606 KiB MTD/Vertices
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Aug 22, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@fabiocos fabiocos deleted the fc-updateValid20240807 branch October 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants