Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a dead assignment in DQM/SiStripCommissioningSources/src/FineDelayTask.cc #45660

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Remove a dead assignment in DQM/SiStripCommissioningSources/src/FineDelayTask.cc #45660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions DQM/SiStripCommissioningSources/src/FineDelayTask.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,20 +87,20 @@ void FineDelayTask::fill(const SiStripEventSummary& summary, const edm::DetSet<S
latencyShift -= 64; // allow negative values: we cover [-32,32].. should not be needed.
if ((latencyCode >> 6) == 2)
latencyShift -= 3; // layer in deconv, rest in peak
if ((latencyCode >> 6) == 1)
else if ((latencyCode >> 6) == 1)
latencyShift += 3; // layer in peak, rest in deconv
float correctedDelay =
float correctedDelayBase =
delay - (latencyShift * 25.); // shifts the delay so that 0 corresponds to the current settings.

LogDebug("Commissioning") << "[FineDelayTask::fill]; the delay is " << delay;
// loop on the strips to find the (maybe) non-zero digi
for (unsigned int strip = 0; strip < digis.data.size(); strip++) {
if (digis.data[strip].adc() != 0) {
// apply the TOF correction
float tof = (digis.data[strip].adc() >> 8) / 10.;
correctedDelay = delay - (latencyShift * 25.) - tof;
if ((digis.data[strip].adc() >> 8) == 255)
continue; // skip hit if TOF is in overflow
// apply the TOF correction
float tof = (digis.data[strip].adc() >> 8) / 10.;
float correctedDelay = correctedDelayBase - tof;
// compute the bin
float nbins = NBINS;
float lowbin = LOWBIN;
Expand Down