Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD Validation: exclude electron isolation module from the official MTD validation sequence #45617

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Aug 1, 2024

PR description:

The MTD electron isolation validation module is removed from the official MTD validation sequence, since it is of limited use for the time being in regular validation. The code is kept in the private test validation configuration for dedicated studies, but it does nto need to be run at any test.

PR validation:

Code tested to remove the desired module in CMSSW_14_1_X_2024-08-01-1100

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • Validation/Configuration (dqm, simulation)
  • Validation/MtdValidation (dqm)

@antoniovagnerini, @civanch, @cmsbuild, @mdhildreth, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@apsallid, @martinamalberti, @missirol, @rovere, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 1, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6cf46/40720/summary.html
COMMIT: 6c02579
CMSSW: CMSSW_14_1_X_2024-08-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45617/40720/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 90 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422822
  • DQMHistoTests: Total failures: 2464
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3420338
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -242.01100000000002 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): -34.573 KiB MTD/ElectronIso
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Aug 2, 2024

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 7, 2024

@cms-sw/dqm-l2 any comment/question/doubt on this PR?

@tjavaid
Copy link

tjavaid commented Aug 8, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9c18817 into cms-sw:master Aug 8, 2024
11 checks passed
@fabiocos fabiocos deleted the fc-updateMTDValid20240801 branch October 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants