Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JME] Add AK8 ParticleNet WvsQCD binarized score in MiniAOD and NanoAOD #45591

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[JME] Add AK8 ParticleNet WvsQCD binarized score in MiniAOD and NanoAOD #45591

merged 1 commit into from
Jul 31, 2024

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR adds the AK8 ParticleNet WvsQCD binarized score in MiniAOD and NanoAOD, which is used to tag boosted W->qq. It is explicitly defined in pfParticleNetFromMiniAODAK8DiscriminatorsJetTags_cfi.py as (probHqq+probHcc)/(probHqq+probHcc+probQCD2hf+probQCD1hf+probQCD0hf).

PR validation:

  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Jul 30, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2024 •
edited
Loading

cms-bot internal usage

@nurfikri89
Copy link
Contributor Author

FYI JME L2, JMAR L3 @abenecke @mcremone @fiemmi @colizz

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45591/41092

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • RecoBTag/ONNXRuntime (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @demuller, @gpetruc, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Jul 30, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Jul 30, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed6296/40693/summary.html
COMMIT: 716916c
CMSSW: CMSSW_14_1_X_2024-07-30-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45591/40693/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 263 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423961
  • DQMHistoTests: Total failures: 305
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3423636
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.064 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.129 KiB Physics/NanoAODDQM
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 77 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 54901
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54901
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.548 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.129 KiB Physics/NanoAODDQM
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.785 2.783 0.002 ( +0.1% ) 3.31 3.33 -0.8% 6.048 6.660
2500.002 2.898 2.897 0.001 ( +0.0% ) 2.95 2.99 -1.3% 6.389 7.011
2500.003 2.844 2.843 0.001 ( +0.0% ) 3.07 3.10 -0.8% 6.365 6.991
2500.011 1.447 1.446 0.001 ( +0.0% ) 5.73 5.76 -0.6% 2.405 2.407
2500.012 1.907 1.906 0.001 ( +0.0% ) 3.14 3.15 -0.4% 2.599 2.589
2500.013 1.762 1.761 0.001 ( +0.1% ) 4.52 4.57 -1.2% 2.508 2.493
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.98 0.91 +7.0% 2.374 2.205
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.93 0.88 +5.5% 2.373 2.206
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.93 0.89 +5.0% 2.247 2.150
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.71 0.70 +1.2% 2.469 2.313
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.88 0.84 +4.1% 2.443 2.306
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.88 0.84 +5.6% 2.411 2.256
2500.033 0.037 0.037 0.000 ( +0.1% ) 0.80 0.75 +7.0% 2.489 2.349
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.81 0.69 +17.4% 2.470 2.338
2500.101 2.643 2.642 0.001 ( +0.0% ) 8.84 8.97 -1.5% 6.935 6.886
2500.111 1.327 1.327 -0.000 ( -0.0% ) 20.12 19.72 +2.1% 2.224 2.208
2500.112 1.732 1.731 0.000 ( +0.0% ) 14.55 14.42 +0.9% 2.303 2.127
2500.131 5.194 5.194 0.000 ( +0.0% ) 15.48 15.95 -2.9% 1.548 1.545
2500.201 2.475 2.475 0.000 ( +0.0% ) 7.42 7.22 +2.8% 6.240 6.124
2500.211 1.589 1.589 -0.000 ( -0.0% ) 17.57 17.30 +1.5% 2.295 2.091
2500.212 2.030 2.030 0.000 ( +0.0% ) 13.95 13.60 +2.6% 2.391 2.123
2500.221 2.006 2.006 0.000 ( +0.0% ) 7.67 7.55 +1.6% 2.438 2.256
2500.222 3.072 3.071 0.000 ( +0.0% ) 7.61 7.46 +2.0% 2.523 2.297
2500.223 8.885 8.884 0.000 ( +0.0% ) 2.80 2.78 +0.8% 2.546 2.309
2500.224 5.512 5.511 0.000 ( +0.0% ) 1.09 1.11 -1.9% 2.584 2.547
2500.225 5.530 5.530 0.000 ( +0.0% ) 1.01 1.01 +0.5% 2.608 2.406
2500.226 2.970 2.970 0.000 ( +0.0% ) 7.50 7.26 +3.3% 2.518 2.281
2500.227 8.972 8.972 0.000 ( +0.0% ) 9.99 10.11 -1.2% 1.520 1.360
2500.231 1.407 1.407 0.000 ( +0.0% ) 13.97 13.72 +1.9% 2.201 2.021
2500.232 2.145 2.145 0.000 ( +0.0% ) 14.01 13.46 +4.1% 2.287 2.030
2500.233 4.668 4.667 0.000 ( +0.0% ) 4.93 4.85 +1.6% 2.311 2.014
2500.234 3.304 3.304 0.000 ( +0.0% ) 1.50 1.51 -0.8% 2.328 2.055
2500.235 3.315 3.314 0.000 ( +0.0% ) 1.39 1.39 -0.1% 2.356 2.134
2500.236 2.082 2.082 0.000 ( +0.0% ) 13.92 13.61 +2.3% 2.286 2.049
2500.237 7.977 7.977 0.000 ( +0.0% ) 14.46 14.60 -1.0% 1.577 1.388
2500.241 9.405 9.405 0.000 ( +0.0% ) 3.88 3.81 +1.7% 1.965 1.937
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.87 0.89 -2.7% 1.728 1.727
2500.243 2.712 2.712 0.000 ( +0.0% ) 7.92 7.91 +0.2% 1.069 1.067
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.55 0.57 -4.3% 1.676 1.582
2500.245 823.158 823.158 0.000 ( +0.0% ) 0.73 0.76 -3.3% 1.671 1.545
2500.901 1.749 1.749 0.000 ( +0.0% ) 21.35 21.40 -0.3% 1.834 1.827
2500.902 1.598 1.598 0.000 ( +0.0% ) 20.80 22.47 -7.4% 1.765 1.750
2500.911 13.931 13.931 0.000 ( +0.0% ) 2.95 2.71 +9.1% 1.079 1.080
2500.912 0.132 0.310 -0.178 ( -57.5% ) 1.35 1.29 +4.9% 0.971 0.964
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.20 1.13 +6.1% 0.971 0.969

hqucms
hqucms reviewed Jul 30, 2024
View reviewed changes
PhysicsTools/NanoAOD/python/jetsAK8_cff.py
@@ -122,6 +122,7 @@
particleNet_XttVsQCD = Var("bDiscriminator('pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HttvsQCD')",float,doc="ParticleNet X->tau_h tau_h vs. QCD score: Xtt/(Xtt+QCD)",precision=10),
particleNet_XtmVsQCD = Var("bDiscriminator('pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HtmvsQCD')",float,doc="ParticleNet X->mu tau_h vs. QCD score: Xtm/(Xtm+QCD)",precision=10),
particleNet_XteVsQCD = Var("bDiscriminator('pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HtevsQCD')",float,doc="ParticleNet X->e tau_h vs. QCD score: Xte/(Xte+QCD)",precision=10),
particleNet_WVsQCD = Var("bDiscriminator('pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:WvsQCD')",float,doc="ParticleNet W->qq vs. QCD score: Xqq+Xcc/(Xqq+Xcc+QCD)",precision=10),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work when reading new MiniAODs that already have pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:WvsQCD stored. For running NANO on existing MiniAODs, the particleNet_WVsQCD branch will get a -1000 because the new discriminant was not available. Is that the intended behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is intended. This is for NanoV15, where Run-3 and Run-2 samples will be reMini (with 15_X, correct me if I am wrong), so there will be no backport to 14_0_X.

@mandrenguyen
Copy link
Contributor

+reconstruction
More XPOG business than reco

@hqucms
Copy link
Contributor

hqucms commented Jul 31, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit deb7809 into cms-sw:master Jul 31, 2024
13 checks passed
@cmsbuild cmsbuild mentioned this pull request Aug 2, 2024
Merged
@nurfikri89 nurfikri89 deleted the from1410pre5_addPNetWvsQCDscore_pr_master branch August 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hqucms hqucms hqucms left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@nurfikri89 @cmsbuild @hqucms @mandrenguyen