-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[140X backport] MTD geometry: fix BTL numbering scheme for scenario v3 #45578
Conversation
…hep without issues
A new Pull Request was created by @fabiocos for CMSSW_14_0_X. It involves the following packages:
@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
test parameters:
|
please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
@srimanob I believe that the error is in the baseline used for comparison, the test with this PR looks ok, please cross check in case |
+1 |
@srimanob , is there a problem with 14_0 update? |
+Upgrade Nope, it can go. Originally, it was just for testing. It is good to be there. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
backport of #45211 |
type mtd |
+1 |
PR description:
Partial backport of #45211 to allow a smooth processing of geometries with BTL secanrio v3 also on DD4hep. This PR addresses the porblem reported by @srimanob in #45513 (comment) .
PR validation:
Workflow 29634.911 runs without any warning in CMSSW_14_0_X_2024-07-29-1100 .