Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[140X backport] MTD geometry: fix BTL numbering scheme for scenario v3 #45578

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

fabiocos
Copy link
Contributor

PR description:

Partial backport of #45211 to allow a smooth processing of geometries with BTL secanrio v3 also on DD4hep. This PR addresses the porblem reported by @srimanob in #45513 (comment) .

PR validation:

Workflow 29634.911 runs without any warning in CMSSW_14_0_X_2024-07-29-1100 .

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 29, 2024

A new Pull Request was created by @fabiocos for CMSSW_14_0_X.

It involves the following packages:

  • Geometry/MTDCommonData (upgrade, geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 29, 2024

cms-bot internal usage

@fabiocos
Copy link
Contributor Author

test parameters:

  • workflows = 24834.911,29634.911

  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8e70e/40671/summary.html
COMMIT: 3981c84
CMSSW: CMSSW_14_0_X_2024-07-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45578/40671/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 71 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 61 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342828
  • DQMHistoTests: Total failures: 1218
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3341590
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 205 log files, 169 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@fabiocos
Copy link
Contributor Author

@srimanob I believe that the error is in the baseline used for comparison, the test with this PR looks ok, please cross check in case

@civanch
Copy link
Contributor

civanch commented Jul 30, 2024

+1

@civanch
Copy link
Contributor

civanch commented Aug 14, 2024

@srimanob , is there a problem with 14_0 update?

@srimanob
Copy link
Contributor

+Upgrade

Nope, it can go. Originally, it was just for testing. It is good to be there.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

backport of #45211

@mandrenguyen
Copy link
Contributor

type mtd

@cmsbuild cmsbuild added the mtd label Aug 14, 2024
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0ea027d into cms-sw:CMSSW_14_0_X Aug 16, 2024
10 checks passed
@fabiocos fabiocos deleted the fc-140Xbp45211 branch October 21, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants