Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error in TTStub.h #45399

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Jul 8, 2024

I fixed it w/o making a issue.
Too trivial to discuss.

found while compiling with clang 19

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

cms-bot internal usage

@VinInn
Copy link
Contributor Author

VinInn commented Jul 8, 2024

As usual with template functions: do not ask how it compiled this now

@VinInn
Copy link
Contributor Author

VinInn commented Jul 8, 2024

@cmsbuild : please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45399/40849

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@VinInn
Copy link
Contributor Author

VinInn commented Jul 8, 2024

DO not understand
code check just removed that tab!

I do not have time to fight against these things.
please fix . (whoever feels responsible)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

A new Pull Request was created by @VinInn for master.

It involves the following packages:

  • DataFormats/L1TrackTrigger (l1, upgrade)

@aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere, @sviret this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa2e33/40283/summary.html
COMMIT: 85764fd
CMSSW: CMSSW_14_1_X_2024-07-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45399/40283/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345065
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants