Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectSelectorBase add option to not throw on missing input #45385

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 5, 2024

fixes #45384

PR description:

Title say it all, and use it to fix workflows broken as pointed out in #45384 (comment)

PR validation:

runTheMatrix.py -l 1001.3 runs with this addition.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Jul 5, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Jul 5, 2024

test parameters:

  • workflows = 1001.3, 1001.4, 1002.3, 1002.4

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • CommonTools/UtilAlgos (reconstruction)

@cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@adewit, @missirol, @mmusich, @pakhotin, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 5, 2024

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Jul 5, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193358/40259/summary.html
COMMIT: f28a540
CMSSW: CMSSW_14_1_X_2024-07-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45385/40259/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1001.3 step 2
1001.4 step 2
1002.3 step 2
1002.4 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 664 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345065
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 210 log files, 169 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193358/40268/summary.html
COMMIT: 1c05e6f
CMSSW: CMSSW_14_1_X_2024-07-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45385/40268/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1001.3 step 2
1001.4 step 2
1002.3 step 2
1002.4 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 672 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345059
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 210 log files, 169 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 8, 2024

+1

@mmusich
Copy link
Contributor Author

mmusich commented Jul 8, 2024

urgent

  • I believe this should remove failures from IB workflows.

@cmsbuild cmsbuild added the urgent label Jul 8, 2024
@perrotta
Copy link
Contributor

perrotta commented Jul 8, 2024

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment