-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx358D Correct the XML file for scintillators in the V19 description of HGCal geometry #45382
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45382/40831 |
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Size: This PR adds an extra 60KB to repository
Comparison SummarySummary:
|
+1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Correct the XML file for scintillators in the V19 description of HGCal geometry
PR validation:
Use the corrected version of the conversion code. The final checks will be made when the geometry codes are ready
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special