Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed artificial new files in StreamerInputModule [14.0.9-patchX] #45258

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 18, 2024

PR description:

Quoting @Dr15Jones:

The genuineCloseFile was incorrectly resetting the member which tracked if this is an artificial file boundary. This should fix a problem seen in the ECal online calibration.

PR validation:

Quoting @Dr15Jones:

I ran the test given in a private email and the file is now processed without hitting an assert.

Backport status

backport of #45247

The genuineCloseFile was incorrectly resetting the member which
tracked if this is an artificial file boundary.
@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 18, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 18, 2024

backport #45247

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 18, 2024

urgent

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_9_patchX.

It involves the following packages:

  • IOPool/Streamer (core)

@cmsbuild, @Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit, @makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
Note that this branch is designed for requested bug fixes specific to the CMSSW_14_0_9 release.
If you wish to make a pull request for the CMSSW_14_0_X release cycle, please use the CMSSW_14_0_X branch instead

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2024

cms-bot internal usage

@antoniovilela
Copy link
Contributor

+1

  • As discussed in ORP meeting.

@antoniovilela
Copy link
Contributor

@smuzaffar
Will merge once Core signs.

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f400eab into cms-sw:CMSSW_14_0_9_patchX Jun 18, 2024
2 of 3 checks passed
@smuzaffar
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_9_patchX IBs after it passes the integration tests.

@fwyzard fwyzard deleted the fixStreamerInputModule_14_0_9 branch June 24, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants