Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of sexaquark simulation code (for EXO-24-003) #44992

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

lowette
Copy link
Contributor

@lowette lowette commented May 17, 2024

CMSSW integration of sexaquark simulation code.

This PR adds code for sexaquark simulation starting from HepMC input files. It adds the new sexaquark particles, the inelastic interaction, the neutron annihilation, and a looping mechanism to increase the chance of an interaction, plus other necessary classes and files. CustomPhysicsList is extended to this new interaction for the anti-sexaquark.

Nothing in ordinary CMS running should be affected, GEANT will only use this code when a particle with pdgId -1020000020 is found (which is the proper code for a sexaquark of content uuddss).

This code integration happens following the presentation in the EXO MC&I meeting here:
https://indico.cern.ch/event/1379001/#3-sexaquark-simulation-in-cmss
We were requested to integrate the sexaquark simulation code, and to validate our private productions with a central simulation. For the latter, we will want to do a backport to CMSSW_10_2_X once merged in the master.

The code was tested in the latest 14_1_X integration build using the new python config added in the CustomPhysics/test directory.
This was not expected to affect any runTheMatrix tests. I ran the tests for completeness (runTheMatrix.py -l limited -i all --ibeos) which flagged no problems.

+CC @vetens

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44992/40274

  • This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44992/40276

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lowette for master.

It involves the following packages:

  • SimG4Core/CustomPhysics (simulation)

@mdhildreth, @cmsbuild, @civanch can you please review it and eventually sign? Thanks.
@rovere, @bsunanda, @slomeo, @makortel, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@lowette lowette marked this pull request as ready for review May 17, 2024 09:40
@civanch
Copy link
Contributor

civanch commented May 17, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1bbb4/39427/summary.html
COMMIT: 5804b9c
CMSSW: CMSSW_14_1_X_2024-05-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44992/39427/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338950
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jun 1, 2024

@smuzaffar , sorry, I cannot interpret tests as "approved". This does not related to this PR but bot report is not clear to me.

@smuzaffar
Copy link
Contributor

please test

lets re-run to get clean tests: see #45116

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1bbb4/39657/summary.html
COMMIT: 8e4943c
CMSSW: CMSSW_14_1_X_2024-06-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44992/39657/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338833
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jun 1, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aaaff09 into cms-sw:master Jun 3, 2024
11 checks passed
@cmsbuild cmsbuild mentioned this pull request Jun 4, 2024
3 tasks
lowette added a commit to lowette/cmssw that referenced this pull request Jun 4, 2024
…quark simulation code. Backport needed to run simulation for 2018 conditions and validate private simulation.
lowette added a commit to lowette/cmssw that referenced this pull request Jun 4, 2024
cmsbuild added a commit that referenced this pull request Jun 6, 2024
Backport of PR #44992 for sexaquark simulation code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants