[DT] Position fix and new filter to TPs from Phase2 L1T emulator

[jfernan2]

PR description:

This PR fixes a bug in the positions retrieved by the DT L1T Phase2 emulator (credits to @javi-llorente ) and applies a coincidence filter to the resulting Trigger Primitives (credits to @dermotmoran ).

It constitutes the v2.1 of the AM algorithm, fixing v2.0 and recovering efficiency losses to the levels of the original v1.0

PR validation:

Talks explaining the problem and supporting this change:

Report from J. F de Troconiz: AM v2 Emulator Global Phi / Phi_B Assignment
https://indico.cern.ch/event/1416436/contributions/5953406/attachments/2857442/4999143/DT_TS_Ph2_24_may.pdf

Coincidence filter by D. Moran:
https://indico.cern.ch/event/1425784/contributions/5998104/attachments/2876917/5038456/dt_co.pdf

Talk by J. Llorente explaining the fix in the DT Upgrade meeting:
https://indico.cern.ch/event/1435604/contributions/6040623/attachments/2894593/5074862/llorenteDT.pdf

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40199

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

• L1Trigger/DTTriggerPhase2 (upgrade, l1)

@aloeliger, @epalencia, @srimanob, @subirsarkar, @cmsbuild can you please review it and eventually sign? Thanks.
@battibass, @Martin-Grunewald, @missirol, @JanFSchulte this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40202

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #44924 was updated. @srimanob, @subirsarkar, @aloeliger, @epalencia, @cmsbuild can you please check and sign again.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40223

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40223/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44924/40223/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[aloeliger]

@cms-sw/upgrade-l2 just a ping on the signature

[jfernan2]

@srimanob can you sign this pr please?

[srimanob]

+Upgrade

[srimanob]

@cmsbuild please test

Just to refresh the test.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc4141/41242/summary.html
COMMIT: 26adbda
CMSSW: CMSSW_14_2_X_2024-09-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44924/41242/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328315
• DQMHistoTests: Total failures: 58
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328237
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: found differences in 2 / 42 workflows

[srimanob]

Hi @aloeliger @jfernan2
I think the change is expected, we see change in Phase-2 workflows. One strange is that we see more failure comparisons from DDD on L1T, than DD4hep. I assume it should be the same order. Not so clear why.

[jfernan2]

Hi @srimanob
Yes, changes[1] in Phase2 L1T Muons are expected, since we are fixing DT Trigger Primitives
The differences between DD4hep and DDD I believe that are due to the stats of muons from TTbar in samples, which seem to be larger on DDD, hence more histograms susceptible to changes
[1] https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_2_X_2024-09-02-2300+bc4141/64313/dqm-histo-comparison-summary.html

[mandrenguyen]

+1